PLAT-72712 - i18n: lifecycle method updates per locale prop update #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Derek Tor <derek.tor@lge.com>
ryanjduffy
approved these changes
Jan 31, 2019
There was a problem hiding this comment.
👍 Good work, @rundmt! Even though we're updating state in componentDidUpdate, I think this enforces the correct order of operations as originally implemented in the async ilib updates. It would be possible to update state in {{getDerivedStateFromProps}} but that would cause the state to be out of sync with ilib's internal state. By deferring to componentDidUpdate, we ensure that the internal state update doesn't occur until after ilib has updated (either synchronously or asynchronously).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I have read and understand the contribution guide
A CHANGELOG entry is included
At least one test case is included for this feature or bug fix
Documentation was added or is not needed
This is an API breaking change
Issue Resolved / Feature Added
Needed to update i18n to use new lifecycle methods
Resolution
Updated to use safe lifecycle methods
Additional Considerations
Originally I tried to make make use of
getDerivedStateFromProps, but using async things in there is not recommended. So I ended up putting it incomponentDidUpdate.reactjs/rfcs#26
Links
PLAT-72712