Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-129000: Apply voice intent only when scroll is possible #2888

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

changgilee
Copy link
Contributor

@changgilee changgilee commented Jan 12, 2021

Checklist

  • I have read and understand the contribution guide

  • A CHANGELOG entry is included

  • At least one test case is included for this feature or bug fix

  • Documentation was added or is not needed

  • This is an API breaking change

Issue Resolved / Feature Added

In current status, voice intent is always declared

Resolution

Apply voice intent only when scroll is possible

Additional Considerations

N/A

Links

PLAT-129000

Comments

N/A

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #2888 (342259f) into develop (4387152) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2888      +/-   ##
===========================================
+ Coverage    45.82%   45.92%   +0.09%     
===========================================
  Files          166      166              
  Lines         8294     8309      +15     
  Branches      2021     2023       +2     
===========================================
+ Hits          3801     3816      +15     
  Misses        3377     3377              
  Partials      1116     1116              
Impacted Files Coverage Δ
packages/ui/useScroll/useScroll.js 41.04% <100.00%> (+0.56%) ⬆️
packages/ui/A11yDecorator/A11yDecorator.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4387152...342259f. Read the comment docs.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants