Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Converter is already registered" deprecation warning. #9512

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

noamkush
Copy link
Contributor

Description

Raised by another at #9495. This avoids creating the converter entirely if it is already registered.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible yes. Thanks.

@carltongibson carltongibson merged commit 5cc1028 into encode:master Aug 26, 2024
7 checks passed
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also update the tests?

@carltongibson
Copy link
Collaborator

@auvipy please do! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants