Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend param to ASGIDispatcher #270

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Add backend param to ASGIDispatcher #270

merged 1 commit into from
Aug 23, 2019

Conversation

florimondmanca
Copy link
Member

Fixes #247

@sethmlarson sethmlarson merged commit 31748a3 into master Aug 23, 2019
@sethmlarson
Copy link
Contributor

Thanks @florimondmanca!

@cansarigol
Copy link
Contributor

Hi, it was merged but is there any obstacle for this:backend: ConcurrencyBackend = AsyncioBackend() . Just to narrow down #272

@sethmlarson
Copy link
Contributor

Yes, you don't want to use mutable objects as defaults for function parameters because instead of getting a new copy on every call it'll use the same instance.

@cansarigol
Copy link
Contributor

ah sorry 👍

@florimondmanca florimondmanca deleted the feat/asgi-backend-param branch August 23, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ASGI dispatcher asyncio-agnostic
3 participants
@florimondmanca @sethmlarson @cansarigol