Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL parsing tests from WHATWG #3188

Merged
merged 9 commits into from
Jun 13, 2024
Merged

Add URL parsing tests from WHATWG #3188

merged 9 commits into from
Jun 13, 2024

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented May 3, 2024

Add 563 URL parsing test cases from https://url.spec.whatwg.org/

Test cases are from...

TODO:

  • We've got a private import here, which we're avoiding in all our other tests case.
  • Add username/password checks.
  • We've two failing cases here.

Reminder to self follow-ups:

  • Comparison of WHATWG percent-escape set vs. chrome percent-escape set.
  • Exceptions for invalid domain names. *

* eg. see this comment for useful context

@tomchristie tomchristie marked this pull request as ready for review May 3, 2024 09:48
@tomchristie
Copy link
Member Author

Not complete, but suitable for preliminary review.

@tomchristie tomchristie added the user-experience Ensuring that users have a good experience using the library label May 3, 2024
@tomchristie tomchristie requested a review from a team May 17, 2024 17:29
@tomchristie
Copy link
Member Author

Thanks @karpetrosyan. Let's pass on the initial TODO items here, more of a priority to just get this in.

@tomchristie tomchristie merged commit db9072f into master Jun 13, 2024
5 checks passed
@tomchristie tomchristie deleted the whatwg-tests branch June 13, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-experience Ensuring that users have a good experience using the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants