Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document supported async libraries #387

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Document supported async libraries #387

merged 2 commits into from
Sep 26, 2019

Conversation

florimondmanca
Copy link
Member

@florimondmanca florimondmanca commented Sep 25, 2019 •
edited
Loading

Following the addition of trio support via #276.

sethmlarson
sethmlarson approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍 For me it definitely solidifies the idea that we should be auto-detecting which async library, but that's something for another day!

@florimondmanca
Copy link
Member Author

@sethmlarson I added an extra admonition with installation instructions for trio; I think your comment (which it seems you removed?) was relevant.

@sethmlarson
Copy link
Contributor

Eh, I'm wondering if it's needed cuz it's not possible to run trio without trio installed.

@florimondmanca
Copy link
Member Author

Yeah, fair point. Does that mean we don't actually need the [trio] extra?

@sethmlarson
Copy link
Contributor

Probably not!

@florimondmanca florimondmanca mentioned this pull request Sep 26, 2019
Merged
cansarigol
cansarigol approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@cansarigol cansarigol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

pquentin
pquentin reviewed Sep 26, 2019
View reviewed changes
docs/async.md Outdated Show resolved Hide resolved
sethmlarson
sethmlarson approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks yall!

@florimondmanca florimondmanca merged commit 3496525 into master Sep 26, 2019
@florimondmanca florimondmanca deleted the doc/async-libraries branch September 26, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin left review comments

@cansarigol cansarigol cansarigol approved these changes

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florimondmanca @sethmlarson @pquentin @cansarigol