This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Convert remainder of library to TypeScript, Vite build, include type checking in CI #158
Commits on Jan 13, 2023
-
(I've learned my lesson from enketo#157, hopefully this will make it easier to review!)
-
Include app/src in TypeScript and ESLint configs
Adds separate test-specific config for Vitest's globals
-
-
-
-
While adding types, I found some of these names fairly hard to understand. There's some bikeshedding here in terms of name length, of course, but I do think this helps make more of the code self-documenting
-
Add/fix types in markdown.ts, fix linter warnings
Again there may be some subjective choices (i.e. `ignoreMatch` and the minor regex changes to avoid passing unnecessary capture groups to replacer functions), but I think it makes the intent more clear
-
-
-
-
-
-
Per discussion, the README is sufficient and more useful documentation
-
Fix build, a few errors found in core and express
- Fixes Vite build - Fixes `tsc` - Adds types for config/build.shared.js - Uses shared build config where possible - Adds typedef emit - Fixes reference to `config.json` which works locally but failed in CI -
-
Mark internal exports as package-private
This also removes backwards compatibility considerations for those
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.