Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled or hidden element might get focused in a modal dialog #1689

Closed
ashklianko opened this issue Jan 6, 2021 · 0 comments
Closed

Disabled or hidden element might get focused in a modal dialog #1689

ashklianko opened this issue Jan 6, 2021 · 0 comments
Assignees
@ashklianko
Labels
Bug Something isn't working

Comments

@ashklianko
Copy link
Member

Current logic is to try to focus first registered tabbable element in spite of it might be disabled or hidden
@ashklianko ashklianko self-assigned this Jan 6, 2021
ashklianko added a commit that referenced this issue Jan 6, 2021
@ashklianko
ModalDialog: focus first tabbable element when focus leaves dialog #1689
98b7276
@alansemenov alansemenov added the Bug Something isn't working label Jan 7, 2021
@alansemenov alansemenov changed the title ModalDialog: focus first tabbable element when focus leaves dialog Disabled or hidden element might get focused in a modal dialog Jan 7, 2021
alansemenov pushed a commit that referenced this issue Jan 7, 2021
@ashklianko @alansemenov
ModalDialog: focus first tabbable element when focus leaves dialog #1689
f76e0bc
alansemenov pushed a commit that referenced this issue Jan 7, 2021
@ashklianko @alansemenov
ModalDialog: focus first tabbable element when focus leaves dialog #1689
91ff1b1 


(cherry picked from commit f76e0bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashklianko ashklianko

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashklianko @alansemenov