Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip notification about failed Websockets connection when XP is unavailable #1946

Closed
ashklianko opened this issue May 15, 2021 · 0 comments
Closed

Skip notification about failed Websockets connection when XP is unavailable #1946

ashklianko opened this issue May 15, 2021 · 0 comments
Assignees
@ashklianko
Labels
Bug Something isn't working Not in Changelog Quick fixes

Comments

@ashklianko
Copy link
Member

ashklianko commented May 15, 2021 •
edited
Loading

Need to update ConnectionDetector: adding poll listeners to notify when next connection status check is performed

@alansemenov commented on Wed Aug 12 2020

When XP is unavailable, we show notifications both about that and that Websockets fail to connect. The first one is enough. The second one should only be shown when XP is running normally but browser cannot establish Websockets connection.

image
@ashklianko ashklianko self-assigned this May 15, 2021
@ashklianko ashklianko added the Bug Something isn't working label May 15, 2021
ashklianko added a commit that referenced this issue May 15, 2021
@ashklianko
Skip notification about failed Websockets connection when XP is unava…
ff02835 
…ilable #1946

-Adding poll listeners in connection detector to notify when next poll is done and all actual connection meta is updated
@ashklianko ashklianko mentioned this issue May 15, 2021
Merged
alansemenov pushed a commit that referenced this issue May 17, 2021
@ashklianko @alansemenov
Skip notification about failed Websockets connection when XP is unava…
a03a1d1 
…ilable #1946

-Adding poll listeners in connection detector to notify when next poll is done and all actual connection meta is updated
alansemenov pushed a commit that referenced this issue May 17, 2021
@ashklianko @alansemenov
Skip notification about failed Websockets connection when XP is unava…
8ffbd94 
…ilable #1946

-Adding poll listeners in connection detector to notify when next poll is done and all actual connection meta is updated

(cherry picked from commit a03a1d1)
@alansemenov alansemenov added the Not in Changelog Quick fixes label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashklianko ashklianko

Labels
Bug Something isn't working Not in Changelog Quick fixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashklianko @alansemenov