Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ItemSet occurrence gets instantly validated #2333

Closed
ashklianko opened this issue Dec 22, 2021 · 1 comment
Closed

New ItemSet occurrence gets instantly validated #2333

ashklianko opened this issue Dec 22, 2021 · 1 comment
Assignees
@ashklianko
Labels
Bug Something isn't working
Milestone
4.1.1

Comments

@ashklianko
Copy link
Member

@ashklianko commented on Mon Dec 20 2021

Recently we had newly added item validated only after saving or adding next item
@ashklianko ashklianko mentioned this issue Dec 22, 2021
Closed
@ashklianko ashklianko self-assigned this Dec 22, 2021
@ashklianko ashklianko added the Bug Something isn't working label Dec 22, 2021
ashklianko added a commit that referenced this issue Dec 22, 2021
@ashklianko
New ItemSet occurrence gets instantly validated #2333
8d637f7 
-regression issue from fix of #1964
-Added validateOccurrenceOnAdd param to let form items with occurrences toggle validation of newly added occurrences on demand
alansemenov pushed a commit that referenced this issue Jan 5, 2022
@ashklianko @alansemenov
New ItemSet occurrence gets instantly validated #2333
07573f4 
-regression issue from fix of #1964
-Added validateOccurrenceOnAdd param to let form items with occurrences toggle validation of newly added occurrences on demand
alansemenov added a commit that referenced this issue Jan 5, 2022
@alansemenov
Consistent naming (#2333)
0112a82
alansemenov added a commit that referenced this issue Jan 5, 2022
@ashklianko @alansemenov
New ItemSet occurrence gets instantly validated #2333 (#2335)
11024ae 
* New ItemSet occurrence gets instantly validated #2333

-regression issue from fix of #1964
-Added validateOccurrenceOnAdd param to let form items with occurrences toggle validation of newly added occurrences on demand

* Consistent naming (#2333)

Co-authored-by: Alan Semenov <ase@enonic.com>
@alansemenov alansemenov reopened this Jan 5, 2022
@alansemenov
Copy link
Member

@ashklianko after the new changes the content itself doesn't become invalid after adding a new (not yet valid) occurrence

ashklianko added a commit that referenced this issue Jan 10, 2022
@ashklianko
New ItemSet occurrence gets instantly validated #2333
2a3b2f1 
-reverting adding validateOccurrenceOnAdd param
ashklianko added a commit that referenced this issue Jan 10, 2022
@ashklianko
New ItemSet occurrence gets instantly validated #2333
2c2714f 
-add occurrence buttons are using 'createAndAddOccurrence' method, I've updated it to use css to hide validation error immediately after occurrence is created and validated, and show it on next call to validate()
-Updated app config dialog to override form styling and force showing  validation error for newly added occurrence
alansemenov pushed a commit that referenced this issue Jan 10, 2022
@ashklianko @alansemenov
New ItemSet occurrence gets instantly validated #2333
8eb6bde 
-reverting adding validateOccurrenceOnAdd param
alansemenov pushed a commit that referenced this issue Jan 10, 2022
@ashklianko @alansemenov
New ItemSet occurrence gets instantly validated #2333
0308a7a 
-add occurrence buttons are using 'createAndAddOccurrence' method, I've updated it to use css to hide validation error immediately after occurrence is created and validated, and show it on next call to validate()
-Updated app config dialog to override form styling and force showing  validation error for newly added occurrence
alansemenov pushed a commit that referenced this issue Jan 10, 2022
@ashklianko @alansemenov
New ItemSet occurrence gets instantly validated #2333 (#2335)
f74850c 
* New ItemSet occurrence gets instantly validated #2333

-regression issue from fix of #1964
-Added validateOccurrenceOnAdd param to let form items with occurrences toggle validation of newly added occurrences on demand

* Consistent naming (#2333)

Co-authored-by: Alan Semenov <ase@enonic.com>
(cherry picked from commit 11024ae)
alansemenov pushed a commit that referenced this issue Jan 10, 2022
@ashklianko @alansemenov
New ItemSet occurrence gets instantly validated #2333
549b6e6 
-reverting adding validateOccurrenceOnAdd param

(cherry picked from commit 8eb6bde)
alansemenov pushed a commit that referenced this issue Jan 10, 2022
@ashklianko @alansemenov
New ItemSet occurrence gets instantly validated #2333
458c418 
-add occurrence buttons are using 'createAndAddOccurrence' method, I've updated it to use css to hide validation error immediately after occurrence is created and validated, and show it on next call to validate()
-Updated app config dialog to override form styling and force showing  validation error for newly added occurrence

(cherry picked from commit 0308a7a)
alansemenov added a commit that referenced this issue Jan 10, 2022
@alansemenov
New ItemSet occurrence gets instantly validated (4.1.1) (#2356)
294909e 
New ItemSet occurrence gets instantly validated #2333
@alansemenov alansemenov added this to the 4.1.1 milestone Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashklianko ashklianko

Labels
Bug Something isn't working
Projects
None yet
Milestone
4.1.1
Development

No branches or pull requests
2 participants
@ashklianko @alansemenov