Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrincipalSelector shouldn't be registered in the InputType registry #2448

Closed
alansemenov opened this issue Mar 7, 2022 · 0 comments
Closed

PrincipalSelector shouldn't be registered in the InputType registry #2448

alansemenov opened this issue Mar 7, 2022 · 0 comments
Assignees
@alansemenov
Labels
Bug Something isn't working
Milestone
4.1.3

Comments

@alansemenov
Copy link
Member

PrincipalSelector registers itself in the InputType registry, but this doesn't make sense because PrincipalLoader is using API that it specific to each system app. Instead, app-specific PrincipalSelector classes (deriving from the base class PrincipalSelector in lib-admin-ui) should register themselves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alansemenov alansemenov

Labels
Bug Something isn't working
Projects
None yet
Milestone
4.1.3
Development

No branches or pull requests
1 participant
@alansemenov