Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio button value should not be used for item-set label #2546

Closed
alansemenov opened this issue May 5, 2022 · 1 comment
Closed

Radio button value should not be used for item-set label #2546

alansemenov opened this issue May 5, 2022 · 1 comment
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@alansemenov
Copy link
Member

If an item set contains an option set where one of the options contains a radio group with a radio button selected by default, value of this radio button (option.value) will be used for the item-set's header and won't be overridden even if a text field before the radio group is filled in.

image

@alansemenov alansemenov added the Bug Something isn't working label May 5, 2022
@alansemenov alansemenov self-assigned this May 5, 2022
@alansemenov alansemenov added this to the 4.2.1 milestone May 11, 2022
@alansemenov
Copy link
Member Author

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<content-type>
  <display-name>Blog</display-name>
  <super-type>base:structured</super-type>
  <form>
    <item-set name="linkListData">
      <label>Link</label>
      <items>
        <item-set name="link">
          <label>optionLink</label>
          <occurrences minimum="1" maximum="1"/>
          <items>
            <option-set name="optionlink">
              <label>Optionlink</label>
              <expanded>false</expanded>
              <occurrences minimum="0" maximum="1"/>
              <options minimum="1" maximum="1">
                <option name="content">
                  <label>Content</label>
                  <items>
                    <input name="text" type="TextLine">
                      <label>Link text</label>
                      <occurrences minimum="0" maximum="1"/>
                      <help-text>Will fall back to content displayName if not set</help-text>
                    </input>
                    <input name="target" type="RadioButton">
                      <label>Target</label>
                      <help-text>The target attribute specifies where to open the linked document
                      </help-text>
                      <occurrences minimum="0" maximum="0"/>
                      <config>
                        <option value="_self">Same frame</option>
                        <option value="_blank">New window or tab</option>
                      </config>
                      <default>_self</default>
                    </input>
                  </items>
                </option>
                <option name="url">
                  <label>Url</label>
                  <items>
                    <input name="text" type="TextLine">
                      <label>Link text</label>
                      <occurrences minimum="0" maximum="1"/>
                    </input>
                    <input name="target" type="RadioButton">
                      <label>Target</label>
                      <help-text>The target attribute specifies where to open the linked document
                      </help-text>
                      <occurrences minimum="0" maximum="0"/>
                      <config>
                        <option value="_self">Same frame</option>
                        <option value="_blank">New window or tab</option>
                      </config>
                    </input>
                  </items>
                </option>
                <option name="attachment">
                  <label>Attachment</label>
                  <items>
                    <input name="text" type="TextLine">
                      <label>Link text</label>
                      <occurrences minimum="0" maximum="1"/>
                      <help-text>Will fall back to attachment displayName if not set</help-text>
                    </input>
                    <input name="download" type="RadioButton">
                      <label>Download?</label>
                      <help-text>Set to true if the disposition header should be set to attachment, false if it should be set to inline
                      </help-text>
                      <occurrences minimum="0" maximum="0"/>
                    </input>
                  </items>
                </option>
              </options>
            </option-set>
          </items>
        </item-set>
      </items>
      <occurrences minimum="0" maximum="0"/>
    </item-set>
  </form>
</content-type>

alansemenov added a commit that referenced this issue May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant