Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help text and counter overlap for TextLine input #2594

Closed
alansemenov opened this issue May 24, 2022 · 2 comments
Closed

Help text and counter overlap for TextLine input #2594

alansemenov opened this issue May 24, 2022 · 2 comments
Assignees
@reisfmb
Labels
Bug Something isn't working
Milestone
4.2.2

Comments

@alansemenov
Copy link
Member

When a TextLine input has both help-text and config.showCounter, then help text and counter will overlap:
image

Solution is to apply right padding to the help-text div when it's preceded by an input with both text-input-type and show-counter styles applied. Also check if we have the same issue with TextArea.

image
@alansemenov alansemenov added the Bug Something isn't working label May 25, 2022
reisfmb added a commit that referenced this issue May 25, 2022
@reisfmb
Help Text right padding if show counter is true (#2594)
ce7d605
reisfmb added a commit that referenced this issue May 26, 2022
@reisfmb
Help Text right padding if show counter is true (#2594)
4ea2b62
alansemenov pushed a commit that referenced this issue May 30, 2022
@reisfmb @alansemenov
Help Text right padding if show counter is true (#2594)
5b2c690
alansemenov pushed a commit that referenced this issue May 30, 2022
@reisfmb @alansemenov
Help Text right padding if show counter is true (#2594)
8aaceb9
@alansemenov alansemenov added this to the 4.2.2 milestone May 30, 2022
alansemenov pushed a commit that referenced this issue May 30, 2022
@reisfmb @alansemenov
Help Text right padding if show counter is true (#2594)
252fe84
@jsi
Copy link
Member

jsi commented May 30, 2022

This bug is fixed for show-counter, but not for max-length. We need a fix for max length as well. See discussion with Tom Arild on Slack today (comments on my announcement of the release).

@reisfmb
Copy link
Contributor

reisfmb commented May 30, 2022 •
edited
Loading

@jsi Thank you. Will fix it today: #2598

@reisfmb reisfmb mentioned this issue May 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reisfmb reisfmb

Labels
Bug Something isn't working
Projects
None yet
Milestone
4.2.2
Development

No branches or pull requests
3 participants
@jsi @alansemenov @reisfmb