-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default localhost vhost #189
Comments
investigate this after 1.0.0 milestone. |
How will I as an super admin get access to 8080/ if this localhost vhost is not pre-defined.? |
default config is located in vhost-defaults.cfg file |
NOTE: enable |
The main problem with localhost vhost - is that it can be abused by developers who create a http request to localhost and think it is a "brilliant idea". As we know such creative idea leads to positive-feedback-loops and must be prevented at all costs. |
we need vhost config which would be added to all xp deployments - base vhost config. This way operator users could specify virtual hosts without need to setting up ingresses. Use cases:
Customizing base vhost config per instance seem to be out of scope right now. We either need to find out how to configure "extra-config" from terraform or move base vhost config to values |
Now we always add localhost vhost to deployments to be able to easily use
kubectl port-forward
. Remove that default vhost!The text was updated successfully, but these errors were encountered: