Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Properly handle template branch names that contain a forward slash #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

foosel
Copy link
Contributor

@foosel foosel commented Aug 29, 2013

If the templateBranchName is a branch containing a forward slash (e.g. dev/v1.0) this leads to errors when trying to retrieve the job's config from Jenkins (since Jenkins interprets the / as part of the URL and therefore throws a 404). This PR runs the templateBranchName through the same conversion (/ -> _) as the job names created from git branches. Thus, for a templateBranchName like the above example, the expected name of the template job is dev_v1.0, matching the general pattern the script expects.

@michaelglass
Copy link

fyi: workaround is to have origin/branch_name as the branch name in your template project (for us, we use origin/master)

@kschzt
Copy link

kschzt commented Aug 6, 2014

+1 - thank you, this works (workaround did not)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants