Refactor: Better Projections #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to keep usage consistent
prevents using one DbContext for multiple snapshots (and therefore prevents related snapshots)
Tests should be running in TestMode, and should not actually commit data.
…d/delete tags/leases, must use the I(Add/Delete)(Leases/Tags)Command interface
- use ITransaction and ITransactionCommand as inputs to GetProjectionIdOrDefault and Reduce (gives access to command and agent signature)
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
1. Load - requires existing stream 2. Create - assumes a new stream 3. First message for Create is always Version.One so that optimistic concurrency exceptions get logged 4. Rename Stage to Append to be consistent 5. Allow Append without Message Key 6. Allow Deltas to manage leases/tags
the-avid-engineer
had a problem deploying
to
beta
GitHub Actions
Failure
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
the-avid-engineer
had a problem deploying
to
beta
GitHub Actions
Error
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
1. attributes belong to sources, not states 2. move TimeStamp from ValueObjects to Sources 3. move Pointer and Version to states, prefix with State 4. move Id to top level abstraction 5. don't pass message key directly to Append, check if delta implements IAddMessageKeyDelta 6. refactor Message.NewMessage to handle all lease collection (entities in the future might have key support?) 7. move Key to common, replace with IStateKey and IMessageKey in abstractions 8. move pointer satisfied check to the exception it always ends up throwing if fall
the-avid-engineer
had a problem deploying
to
beta
GitHub Actions
Failure
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
not all appends are async.. wasted on non-async appends
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
stripe test mode webhook doesn't send an idempotency key :/
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
the-avid-engineer
temporarily deployed
to
beta
GitHub Actions
Inactive
…eat the lookup logic over and over
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.