Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkout default ref when checking out code #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hw-knowit
Copy link
Contributor

Would previously try to check out HEAD_REF on PR or REF_NAME on branch, thus trying to checkout a fork-branch that does not exist in main repo. actions/checkout should handle this just fine without overriding ref.

See current errors on #129:
Screenshot 2024-10-03 at 11 29 34
Screenshot 2024-10-03 at 11 29 37

Supersedes #131.

Would previously try to check out HEAD_REF on PR or REF_NAME on branch,
thus trying to checkout a fork-branch that does not exist in main repo.
actions/checkout should handle this just fine without overriding ref.
@hw-knowit hw-knowit requested a review from a team as a code owner October 4, 2024 13:41
@bvestli bvestli changed the title Checkout default ref when checking out code fix: checkout default ref when checking out code Oct 7, 2024
@Glenn-Terjesen
Copy link
Contributor

Hei, vi bruker den logikken for å sørge for at vi sjekker ut HEAD i branch, selv i en PR, det er derfor det er litt ekstra.. vi kan sikkert gjøre den litt smidigere, men den bør være der.
ref:
image

@hw-knowit
Copy link
Contributor Author

hw-knowit commented Oct 8, 2024

Men hvorfor trengs det egentlig? Som nevnt, dette brekker PR fra fork fordi den prøver å sjekke ut en branch som kun finnes på fork - men defaulten skal fungere helt fint for dette. Jeg ser argumentet dersom den trengs for å generere navn fra branch navn, men det er jo ikke tilfelle for disse jeg har endret her.

@Glenn-Terjesen
Copy link
Contributor

Glenn-Terjesen commented Oct 8, 2024

Men hvorfor trengs det egentlig? Som nevnt, dette brekker PR fra fork fordi den prøver å sjekke ut en branch som kun finnes på fork - men defaulten skal fungere helt fint for dette. Jeg ser argumentet dersom den trengs for å generere navn fra branch navn, men det er jo ikke tilfelle for disse jeg har endret her.

Vi har lagd et ladr unntak for public gha- repoer, skal ikke lenger lage PR fra forks 👍

Ps, PR fra fork fungerer ikke fordi workflowene kan ikke nå hemmelighetene i destinasjonsrepoet - og vi trenger hemmelighetene for å verifisere at det teamene og oss lager testes og fungerer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants