ios: utilize engine handle at platform layer #327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
| } | ||
|
|
||
| - (instancetype)initWithEngine:(envoy_engine_t)engine observer:(EnvoyObserver *)observer { | ||
| - (instancetype)initWithHandle:(envoy_stream_t)streamHandle observer:(EnvoyObserver *)observer { |
There was a problem hiding this comment.
I actually like this approach more than the original engine approach
This is a similar concept to what I was thinking about doing for the java side
Definitely can chat more tomorrow in case we think of a better solution
rebello95
previously approved these changes
Aug 14, 2019
buildbreaker
previously approved these changes
Aug 14, 2019
There was a problem hiding this comment.
Let's go with this for now and we can circle back if/when we think we have something better @goaway
We'll get another opportunity when we introduce the engine handler 😄
Signed-off-by: Mike Schore <mike.schore@gmail.com>
rebello95
approved these changes
Aug 14, 2019
|
recreated here: #329 |
buildbreaker
pushed a commit
that referenced
this pull request
Aug 16, 2019
Updating java library layer to conform to the streaming interfaces changes. Also, tweaks to make the java layer more consistent with the ObjC layer in #327 Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: Updating java library interfaces Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:]
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
Updating java library layer to conform to the streaming interfaces changes. Also, tweaks to make the java layer more consistent with the ObjC layer in envoyproxy/envoy-mobile#327 Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: Updating java library interfaces Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
Updating java library layer to conform to the streaming interfaces changes. Also, tweaks to make the java layer more consistent with the ObjC layer in envoyproxy/envoy-mobile#327 Signed-off-by: Alan Chiu <achiu@lyft.com> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: Updating java library interfaces Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Schore mike.schore@gmail.com