ci: turn on sanitizers

.github/workflows/core.yml

@@ -19,3 +19,35 @@ jobs:
         run: ./ci/mac_ci_setup.sh
       - name: 'Run tests'
         run: bazel test //test/common/...
+  tsan:
+    name: tsan
+    runs-on: ubuntu-18.04
+    timeout-minutes: 45
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - name: 'Install dependencies'
+        run: ./ci/linux_ci_setup.sh
+      - name: 'Run tests'
+        run: |
+          export PATH=/usr/lib/llvm-8/bin:$PATH
+          export CC=clang
+          export CXX=clang++
+          bazel test --config=clang-tsan //test/common/...
+  asan:
+    name: asan
+    runs-on: ubuntu-18.04
+    timeout-minutes: 45
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - name: 'Install dependencies'
+        run: ./ci/linux_ci_setup.sh
+      - name: 'Run tests'
+        run: |
+          export PATH=/usr/lib/llvm-8/bin:$PATH
+          export CC=clang
+          export CXX=clang++
+          bazel test --config=clang-asan //test/common/...

test/common/buffer/bridge_fragment_test.cc

@@ -32,6 +32,7 @@ TEST(BridgeFragmentTest, Basic) {
   ASSERT_EQ(*sentinel, 0);
   buffer_wrapper.drain(buffer_wrapper.length());
   ASSERT_EQ(*sentinel, 1);
+  delete sentinel;
 }
 
 } // namespace Buffer

test/common/buffer/utility_test.cc

@@ -33,6 +33,7 @@ TEST(DataConstructorTest, FromCppToCEmpty) {
   envoy_data c_data = Utility::toBridgeData(empty_data);
 
   ASSERT_EQ(c_data.length, 0);
+  c_data.release(c_data.context);
 }
 
 TEST(DataConstructorTest, FromCppToC) {
@@ -43,6 +44,7 @@ TEST(DataConstructorTest, FromCppToC) {
 
   ASSERT_EQ(c_data.length, s.size());
   ASSERT_EQ(Http::Utility::convertToString(c_data), s);
+  c_data.release(c_data.context);
 }
 
 } // namespace Buffer

test/common/http/dispatcher_test.cc

@@ -158,6 +158,7 @@ TEST_F(DispatcherTest, BasicStream) {
     ASSERT_EQ(Http::Utility::convertToString(c_data), "response body");
     callbacks_called* cc = static_cast<callbacks_called*>(context);
     cc->on_data_calls++;
+    c_data.release(c_data.context);
   };
   bridge_callbacks.on_complete = [](void* context) -> void {
     callbacks_called* cc = static_cast<callbacks_called*>(context);
@@ -752,10 +753,11 @@ TEST_F(DispatcherTest, MultipleDataStream) {
     callbacks_called* cc = static_cast<callbacks_called*>(context);
     cc->on_headers_calls++;
   };
-  bridge_callbacks.on_data = [](envoy_data, bool, void* context) -> void {
+  bridge_callbacks.on_data = [](envoy_data data, bool, void* context) -> void {
     // TODO: assert end_stream and contents of c_data for multiple calls of on_data.
     callbacks_called* cc = static_cast<callbacks_called*>(context);
     cc->on_data_calls++;
+    data.release(data.context);
   };
   bridge_callbacks.on_complete = [](void* context) -> void {
     callbacks_called* cc = static_cast<callbacks_called*>(context);

test/common/http/header_utility_test.cc

@@ -62,13 +62,15 @@ TEST(HeaderDataConstructorTest, FromCToCpp) {
     // Value for the key is the same.
     EXPECT_EQ(cpp_headers->get(expected_key)->value().getStringView(), expected_value);
   }
+  release_envoy_headers(c_headers_copy);
+  delete sentinel;
 }
 
 TEST(HeaderDataConstructorTest, FromCppToCEmpty) {
   HeaderMapImpl empty_headers;
   envoy_headers c_headers = Utility::toBridgeHeaders(std::move(empty_headers));
   ASSERT_EQ(0, c_headers.length);
-  delete[] c_headers.headers;
+  release_envoy_headers(c_headers);
 }
 
 TEST(HeaderDataConstructorTest, FromCppToC) {
@@ -92,7 +94,7 @@ TEST(HeaderDataConstructorTest, FromCppToC) {
     EXPECT_EQ(actual_value, cpp_headers.get(actual_key)->value().getStringView());
   }
 
-  delete c_headers.headers;
+  release_envoy_headers(c_headers);
 }
 
 } // namespace Http