Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-4294 Tidy up generatable/generated/extra functions #108

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

tedjpoole
Copy link
Contributor

General tidy-up to improve consistency:

  • Ensure that all functions that can be generated, are generated
  • Ensure that all functions are in files with the same name
  • Ensure all OpenSSL functions are called via ossl.ossl_()
  • All "extra" functions are now either generated or in the source directory
  • Fixed a valgrind error in CipherTest.cipher1

Signed-off-by: Ted Poole tpoole@redhat.com

Ensure that all functions that can be generated, are generated
Ensure that all functions are in files with the same name
Ensure all OpenSSL functions are called via ossl.ossl_<func>()

Signed-off-by: Ted Poole <tpoole@redhat.com>
Signed-off-by: Ted Poole <tpoole@redhat.com>
@tedjpoole tedjpoole requested a review from dcillera June 28, 2023 13:00
Signed-off-by: Ted Poole <tpoole@redhat.com>
@tedjpoole tedjpoole merged commit e70377b into envoyproxy:main Jun 30, 2023
2 checks passed
@tedjpoole tedjpoole deleted the OSSM-4294-tidy-up branch June 30, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants