Skip to content
This repository has been archived by the owner on Dec 16, 2020. It is now read-only.

Segfault in Context::onResponseHeaders() #180

Closed
mandarjog opened this issue Sep 10, 2019 · 6 comments
Closed

Segfault in Context::onResponseHeaders() #180

mandarjog opened this issue Sep 10, 2019 · 6 comments

Comments

@mandarjog
Copy link
Contributor

1.3.0-rc3

[2019-09-10 14:41:33.541][1820][critical][main] [external/envoy/source/exe/terminate_handler.cc:13] std::terminate called! (possible uncaught exception, see trace)
[2019-09-10 14:41:33.541][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:69] Backtrace (use tools/stack_decode.py to get line numbers):
[2019-09-10 14:41:33.549][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #0: Envoy::TerminateHandler::logOnTerminate()::$_0::operator()() [0x1fdf7d8]
[2019-09-10 14:41:33.558][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #1: [0x1fdf6e9]
[2019-09-10 14:41:33.565][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #2: std::__terminate() [0x2200473]
[2019-09-10 14:41:33.573][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #3: std::__1::__function::__func<>::operator()() [0xba846d]
[2019-09-10 14:41:33.580][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #4: Envoy::Extensions::Common::Wasm::Context::onResponseHeaders() [0xe14774]
[2019-09-10 14:41:33.587][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #5: Envoy::Extensions::Common::Wasm::Context::encodeHeaders() [0xe1a68f]
[2019-09-10 14:41:33.595][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #6: Envoy::Http::ConnectionManagerImpl::ActiveStream::encodeHeaders() [0x1cbaf8b]
[2019-09-10 14:41:33.603][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #7: Envoy::Http::Utility::sendLocalReply() [0x1d69379]
[2019-09-10 14:41:33.612][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #8: Envoy::Http::ConnectionManagerImpl::ActiveStream::sendLocalReply() [0x1cb7161]
[2019-09-10 14:41:33.621][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #9: Envoy::Http::ConnectionManagerImpl::ActiveStream::decodeHeaders() [0x1cb7f2e]
[2019-09-10 14:41:33.630][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #10: Envoy::Http::Http1::ServerConnectionImpl::onMessageComplete() [0x1cca46b]
[2019-09-10 14:41:33.638][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #11: Envoy::Http::Http1::ConnectionImpl::onMessageCompleteBase() [0x1cc93b9]
[2019-09-10 14:41:33.647][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #12: Envoy::Http::Http1::ConnectionImpl::$_7::__invoke() [0x1cccc7d]
[2019-09-10 14:41:33.656][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #13: http_parser_execute [0x1d832cb]
[2019-09-10 14:41:33.664][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #14: Envoy::Http::Http1::ConnectionImpl::dispatchSlice() [0x1cc8728]
[2019-09-10 14:41:33.674][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #15: Envoy::Http::Http1::ConnectionImpl::dispatch() [0x1cc851f]
[2019-09-10 14:41:33.682][1820][critical][backtrace] [bazel-out/k8-opt/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:73] #16: Envoy::Http::ConnectionManagerImpl::onData() [0x1cb49e9]
@mandarjog
Copy link
Contributor Author

@jplevyak @kyessenov

@kyessenov
Copy link
Contributor

Looks like sendLocalReply is the critical bit.

@jplevyak
Copy link
Contributor

What can I do to repro this?

@jplevyak
Copy link
Contributor

This is very odd as the only the only throw in std::function is for a null std::function and we test right about the call if it is null:

Http::FilterHeadersStatus Context::onResponseHeaders() {
if (!wasm_->onResponseHeaders_)
return Http::FilterHeadersStatus::Continue;
if (wasm_->onResponseHeaders_(this, id_) == 0) {
return Http::FilterHeadersStatus::Continue;
}
return Http::FilterHeadersStatus::StopIteration;
}

@jplevyak
Copy link
Contributor

So, without a way to repro I don't have a path forward.

@mandarjog
Copy link
Contributor Author

SendLocalReply is from the blackhole cluster.
Try hitting something that will hit the blackhole cluster. I will try a repro tomorrow.

jplevyak added a commit to jplevyak/envoy-wasm that referenced this issue Sep 13, 2019
@jplevyak
Fix segfault by ensuring that we have created the context in the VM.
f9354c7 
envoyproxy#180

Signed-off-by: John Plevyak <jplevyak@gmail.com>
@jplevyak jplevyak mentioned this issue Sep 13, 2019
Merged
jplevyak added a commit that referenced this issue Sep 13, 2019
@jplevyak
Fix segfault by ensuring that we have created the context in the VM. (#…
fee28ed 
…189)

* Fix segfault by ensuring that we have created the context in the VM.
#180

Signed-off-by: John Plevyak <jplevyak@gmail.com>
jplevyak added a commit to jplevyak/envoy that referenced this issue Sep 17, 2019
@jplevyak
Fix segfault by ensuring that we have created the context in the VM. (i…
fdf6778 
…stio#189)

* Fix segfault by ensuring that we have created the context in the VM.
envoyproxy/envoy-wasm#180

Signed-off-by: John Plevyak <jplevyak@gmail.com>
@jplevyak jplevyak mentioned this issue Sep 17, 2019
Merged
jplevyak added a commit to istio/envoy that referenced this issue Sep 17, 2019
@jplevyak
Fix segfault by ensuring that we have created the context in the VM. (#…
9b1da7c 
…189) (#107)

* Fix segfault by ensuring that we have created the context in the VM.
envoyproxy/envoy-wasm#180

Signed-off-by: John Plevyak <jplevyak@gmail.com>
@emedina emedina mentioned this issue Sep 23, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jplevyak @mandarjog @kyessenov