Skip to content

Commit

Permalink
lds: extract filter chain manager from listener (#7152)
Browse files Browse the repository at this point in the history
Preparation of FCDS. With FCDS the construction of listener and filter chains should be decoupled.
Another motivation is to split the huge listener_manager_impl.cc

This PR is the first step. The new physical design allows future changes at filter chain management without touching much of the listener.

Risk Level: Med
Testing: The test of filterchainmanager is left in listener manager test. Will split in future PRs.

Signed-off-by: Yuchen Dai <silentdai@gmail.com>
  • Loading branch information
lambdai authored and htuch committed Jun 7, 2019
1 parent 55bf28c commit 1e34a2e
Show file tree
Hide file tree
Showing 6 changed files with 593 additions and 525 deletions.
16 changes: 13 additions & 3 deletions source/server/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -253,18 +253,16 @@ envoy_cc_library(
deps = [
":configuration_lib",
":drain_manager_lib",
":filter_chain_manager_lib",
":lds_api_lib",
":transport_socket_config_lib",
"//include/envoy/server:filter_config_interface",
"//include/envoy/server:listener_manager_interface",
"//include/envoy/server:transport_socket_config_interface",
"//include/envoy/server:worker_interface",
"//source/common/api:os_sys_calls_lib",
"//source/common/common:empty_string",
"//source/common/config:utility_lib",
"//source/common/init:manager_lib",
"//source/common/network:cidr_range_lib",
"//source/common/network:lc_trie_lib",
"//source/common/network:listen_socket_lib",
"//source/common/network:resolver_lib",
"//source/common/network:socket_option_factory_lib",
Expand All @@ -280,6 +278,18 @@ envoy_cc_library(
],
)

envoy_cc_library(
name = "filter_chain_manager_lib",
srcs = ["filter_chain_manager_impl.cc"],
hdrs = ["filter_chain_manager_impl.h"],
deps = [
"//include/envoy/server:listener_manager_interface",
"//source/common/common:empty_string",
"//source/common/network:cidr_range_lib",
"//source/common/network:lc_trie_lib",
],
)

envoy_cc_library(
name = "process_context_lib",
hdrs = ["process_context_impl.h"],
Expand Down
Loading

0 comments on commit 1e34a2e

Please sign in to comment.