adding stream_ check

Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
envoyproxy · May 31, 2023 · 3bfe644 · 3bfe644
1 parent 0ebd8c7
commit 3bfe644
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/source/extensions/filters/http/ext_proc/ext_proc.cc b/source/extensions/filters/http/ext_proc/ext_proc.cc
@@ -120,14 +120,16 @@ void Filter::setEncoderFilterCallbacks(Http::StreamEncoderFilterCallbacks& callb
 Filter::StreamOpenState Filter::openStream() {
   // If processing already completes, no need to open a gRPC stream.
   if (processing_complete_) {
-    // Stream failed while starting and either onGrpcError or onGrpcClose was already called
     return sent_immediate_response_ ? StreamOpenState::Error : StreamOpenState::IgnoreError;
   }
   if (!stream_) {
     ENVOY_LOG(debug, "Opening gRPC stream to external processor");
     stream_ = client_->start(*this, grpc_service_, decoder_callbacks_->streamInfo());
-    stats_.streams_started_.inc();
+    if (stream_ == nullptr) {
+      return config_->failureModeAllow() ? StreamOpenState::IgnoreError : StreamOpenState::Error;
+    }
 
+    stats_.streams_started_.inc();
     // For custom access logging purposes. Applicable only for Envoy gRPC as Google gRPC does not
     // have a proper implementation of streamInfo.
     if (grpc_service_.has_envoy_grpc()) {