Skip to content

Commit

Permalink
[Geoip+ci] Fix flaky release check in ci (#36118)
Browse files Browse the repository at this point in the history
<!--
!!!ATTENTION!!!

If you are fixing *any* crash or *any* potential security issue, *do
not*
open a pull request in this repo. Please report the issue via emailing
envoy-security@googlegroups.com where the issue will be triaged
appropriately.
Thank you in advance for helping to keep Envoy secure.

!!!ATTENTION!!!

For an explanation of how to fill out the fields, please see the
relevant section
in
[PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md)
-->

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Partially Fixes #35829
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional [API
Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]

Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@gmail.com>
  • Loading branch information
nezdolik authored Sep 13, 2024
1 parent 209ba63 commit e1af5fa
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ class GeoipProviderTestBase {
Registry::FactoryRegistry<Geolocation::GeoipProviderFactory>::getFactory(
"envoy.geoip_providers.maxmind"));
ASSERT(provider_factory_);
on_changed_cbs_.reserve(1);
}

~GeoipProviderTestBase() {
Expand All @@ -116,6 +115,7 @@ class GeoipProviderTestBase {
Filesystem::Watcher::OnChangedCb cb) {
{
absl::WriterMutexLock lock(&mutex_);
on_changed_cbs_.reserve(1);
on_changed_cbs_.emplace_back(std::move(cb));
}
if (conditional.has_value()) {
Expand Down

0 comments on commit e1af5fa

Please sign in to comment.