Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for adding externally owned data into Envoy's buffer. #2277

Closed
genioshelo opened this issue Dec 28, 2017 · 2 comments
Closed

Add support for adding externally owned data into Envoy's buffer. #2277

genioshelo opened this issue Dec 28, 2017 · 2 comments
Labels
area/perf enhancement Feature requests. Not bugs or questions.

Comments

@genioshelo
Copy link
Contributor

genioshelo commented Dec 28, 2017 •
edited by htuch
Loading

The current evbuffer implementation of Buffer::Instance does not have an API to pass a pointer to externally owned data into the buffer in order to avoid copying. Evbuffer has evbuffer_add_reference which allows this functionality, but the Instance interface needs to be modified to take advantage of this.
@htuch
Copy link
Member

htuch commented Dec 28, 2017 •
edited
Loading

+1, maybe introduce a add_reference method to Buffer and we can achieve this. FTR, this is needed to support filters that manage their own memory with zero copy, e.g. a cache filter.

@mattklein123 mattklein123 added enhancement Feature requests. Not bugs or questions. area/perf labels Dec 29, 2017
@mattklein123
Copy link
Member

Note that I would like to completely replace evbuffer with our own buffer class. That is tracked here: #232

@genioshelo genioshelo mentioned this issue Jan 2, 2018
Merged
jpsim pushed a commit that referenced this issue Nov 28, 2022
@abeyad @jpsim
tools: Enable the VSCode completion db to use bazelisk if available (#…
7430b17 
…2277)

Running tools/vscode_compdb.py to generate the code completion symbols for VSCode produces an error because the .bazelversion in Envoy may not be available in certain environments. The recommendation is to use bazelisk, but the compilation database script defaults to using bazel. This change enables the VSCode compilation database generation script to use bazelisk if it is available on the system; if not, it will use bazel.

Risk Level: low
Testing: local
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Ali Beyad <abeyad@google.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this issue Nov 29, 2022
@abeyad @jpsim
tools: Enable the VSCode completion db to use bazelisk if available (#…
8649062 
…2277)

Running tools/vscode_compdb.py to generate the code completion symbols for VSCode produces an error because the .bazelversion in Envoy may not be available in certain environments. The recommendation is to use bazelisk, but the compilation database script defaults to using bazel. This change enables the VSCode compilation database generation script to use bazelisk if it is available on the system; if not, it will use bazel.

Risk Level: low
Testing: local
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Ali Beyad <abeyad@google.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/perf enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattklein123 @htuch @genioshelo