Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy.reloadable_features.trusted_forwarded_proto deprecation #8842

Closed
alyssawilk opened this issue Nov 1, 2019 · 0 comments · Fixed by #9186
Closed

envoy.reloadable_features.trusted_forwarded_proto deprecation #8842

alyssawilk opened this issue Nov 1, 2019 · 0 comments · Fixed by #9186
Assignees
@alyssawilk
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Milestone
1.13.0

Comments

@alyssawilk
Copy link
Contributor

#7995 (http: forwarding x-forwarded-proto from trusted proxies) introduced a runtime guarded feature. This issue tracks source code cleanup.
@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Nov 1, 2019
@alyssawilk alyssawilk self-assigned this Nov 1, 2019
@mattklein123 mattklein123 added this to the 1.13.0 milestone Nov 1, 2019
@alyssawilk alyssawilk mentioned this issue Dec 2, 2019
Merged
alyssawilk added a commit that referenced this issue Dec 3, 2019
@alyssawilk
http: removing the legacy trusted_forwarded_proto behavior (#9186)
2883067 
Risk Level: Low (removing legacy behavior, which was runtime-flipped off)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Fixes #8842

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

http: removing the legacy trusted_forwarded_proto behavior alyssawilk/envoy
2 participants
@mattklein123 @alyssawilk