Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Windows CI //source/exe:envoy-static build #10293

Merged
merged 49 commits into from
Mar 14, 2020
Merged

Enable Windows CI //source/exe:envoy-static build #10293

merged 49 commits into from
Mar 14, 2020

Commits on Mar 6, 2020

  1. Build instrumentation to get windows compiling 

    - Pick up nameser.h for Windows from c-ares dependency

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    e898398 View commit details
    Browse the repository at this point in the history

  2. Source changes required for Windows compilation 

    Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    68172ea View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Restore PATH until we have a better solution 

    - This PATH is too explicit, and we likely want to use devenv in the
  VC toolkit to resolve the correct build envvars in conjunction with
  the specific build instance. Perhaps a build machine local .bazelrc
  is a possible workaround?

Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe
    wrowe committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    5430979 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Work around bash/powershell/cmd paths disagreements in rules_foreign_cc 

    See bazel-contrib/rules_foreign_cc#334

Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    321464f View commit details
    Browse the repository at this point in the history

  2. Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io> 

    Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe
    wrowe committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    65791f1 View commit details
    Browse the repository at this point in the history

  3. Review mkdir output, try alternate quoting 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    eae1d35 View commit details
    Browse the repository at this point in the history

  4. Review mkdir output, try alternate quoting 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    83fafa2 View commit details
    Browse the repository at this point in the history

  5. Inquiring minds want to know why cmd.exe misbehaves 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    0e2fca7 View commit details
    Browse the repository at this point in the history

  6. Inquiring minds want to know why cmd.exe misbehaves 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    ef7c9b2 View commit details
    Browse the repository at this point in the history

  7. Inquiring minds want to know why cmd.exe misbehaves 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    14709e4 View commit details
    Browse the repository at this point in the history

  8. Inquiring minds want to know why cmd.exe misbehaves 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    e1b89ad View commit details
    Browse the repository at this point in the history

  9. This might fix it 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    2c31401 View commit details
    Browse the repository at this point in the history

  10. Some adjustments to get some info 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    ac48407 View commit details
    Browse the repository at this point in the history

  11. Some adjustments to get some info 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    b9f387c View commit details
    Browse the repository at this point in the history

  12. try a more forceful delete 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    59cd381 View commit details
    Browse the repository at this point in the history

  13. Cleanup debugging 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    3071695 View commit details
    Browse the repository at this point in the history

  14. add back debugging 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    cd5de9a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. add more debugging 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    9d48e56 View commit details
    Browse the repository at this point in the history

  2. Resume experiments, validate cwd of cmd.exe process 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    665a38a View commit details
    Browse the repository at this point in the history

  3. use full path to cmd, arguments that make it less ambiguous 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    de11e79 View commit details
    Browse the repository at this point in the history

  4. try using a cmd script instead of bash 

    - we have to assume the path of the bash mounted filesystem

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    75eed34 View commit details
    Browse the repository at this point in the history

  5. use workingDirectory option to change into git bash filesystem 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    da253d9 View commit details
    Browse the repository at this point in the history

  6. make junction from D:\tmp to C:\tmp 

    - working directory of actual bazel tasks is in D: drive, so /tmp resolves to D:\tmp
- having both covers our bases

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    0a31738 View commit details
    Browse the repository at this point in the history

  7. check on directory structure in actual build step 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    d53f474 View commit details
    Browse the repository at this point in the history

  8. make a junction from /tmp to /c/tmp 

    seems like the original symlink isnt seen by bash

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    3186932 View commit details
    Browse the repository at this point in the history

  9. more debugging 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    cf60035 View commit details
    Browse the repository at this point in the history

  10. try doing the symlink setup in windows_ci_steps.sh 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    7ea9b08 View commit details
    Browse the repository at this point in the history

  11. fix quoting 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    9477979 View commit details
    Browse the repository at this point in the history

  12. only set up D:\ drive and split cmd commands onto separate lines 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    4624402 View commit details
    Browse the repository at this point in the history

  13. try different quoting 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    58fe833 View commit details
    Browse the repository at this point in the history

  14. revert: try different quoting 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    4cbd8e6 View commit details
    Browse the repository at this point in the history

  15. another experiment 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    8d71a04 View commit details
    Browse the repository at this point in the history

  16. Update link to installed software 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    3be02b6 View commit details
    Browse the repository at this point in the history

  17. use builtin azure pipelines tmpdir 

    just print it for now to see what we need to link where

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    ca2f697 View commit details
    Browse the repository at this point in the history

  18. see if this redirection works 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    01e4a1a View commit details
    Browse the repository at this point in the history

  19. adjustments and debugging 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    e87cfb5 View commit details
    Browse the repository at this point in the history

  20. cleanup debugging output 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    7ebcb33 View commit details
    Browse the repository at this point in the history

  21. Merge remote-tracking branch 'origin/master' into test-windows-source… 

    …-build

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    b5ea730 View commit details
    Browse the repository at this point in the history

  22. Latest compilation fixes for recent merge 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    f54ad36 View commit details
    Browse the repository at this point in the history

  23. Add recently added extensions to Windows 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    a24b1e3 View commit details
    Browse the repository at this point in the history

  24. Replace VS2015 with VS2019 for modern C++ stdlib and compilation support 

    Move environment toggles from the ci/ to the .azure-pipelines/

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    2d548f7 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Merge remote-tracking branch 'origin/master' into test-windows-source… 

    …-build

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    e870ee0 View commit details
    Browse the repository at this point in the history

  2. Add comment referencing rules_foreign_cc issue 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    bd55a8c View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Clarify comments on Windows build flags suggested by maintainers 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    a8844d4 View commit details
    Browse the repository at this point in the history

  2. Additional decoration of build flags 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    b8d8b13 View commit details
    Browse the repository at this point in the history

  3. Remove duplicated ci script 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    ce0227c View commit details
    Browse the repository at this point in the history

  4. fastbuild -> opt for Windows 

    - measure time
- fastbuild and debug are producing exes that fail an absl assertion

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @sunjayBhatia @wrowe
    sunjayBhatia and wrowe committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    e3af74a View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into test-windows-source… 

    …-build

Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    b9a5b54 View commit details
    Browse the repository at this point in the history

  6. Re-disable luajit compilation on Windows 

    Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
    @wrowe @sunjayBhatia
    wrowe and sunjayBhatia committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    d4b040d View commit details
    Browse the repository at this point in the history