Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to bazel 3.0.0 #10805

Merged
merged 1 commit into from
Apr 16, 2020
Merged

build: upgrade to bazel 3.0.0 #10805

merged 1 commit into from
Apr 16, 2020

Conversation

lizan
Copy link
Member

@lizan lizan commented Apr 16, 2020

Signed-off-by: Lizan Zhou lizan@tetrate.io

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from keith April 16, 2020 05:42
@asraa
Copy link
Contributor

asraa commented Apr 16, 2020

Just for my own knowledge, how come #9494 doesn't actually break Envoy? eg

"@bazel_tools//platforms:linux",

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizan assuming this is the final upgrade to 3.0, I'm also confused per @asraa as to why there aren't more updates required. Either way, can you please close all of the 3.0 upgrade bazel issue? There are 10-20 of them.

@moderation
Copy link
Contributor

FWIW, I've been compiling Envoy on Bazel 3.0 since it was released including test runs without issues apart from warnings (x86_64 Linux and MacOS and aarch64).

@lizan
Copy link
Member Author

lizan commented Apr 16, 2020

@asraa Looking at bazel issue bazelbuild/bazel#8622 seems the flag isn't flipped in 3.0 but delayed to 4.0.

@mattklein123 I believe some of them are still valid issue but just delayed to a later version. I'll go over them to see whether it is fixed or not.

@lizan lizan merged commit cf7163e into envoyproxy:master Apr 16, 2020
@lizan lizan deleted the bazel_3 branch April 16, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants