access_log: use AccessLogType::NotSet instead of default value #27058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ohadvano <ohadvano@gmail.com>
ohadvano
requested review from
zuercher,
wbpcode,
mattklein123,
lizan,
snowp and
yanavlasov
as code owners
Signed-off-by: ohadvano <ohadvano@gmail.com>
|
Hmmm, sorry, but i didn't get why we need this patch? 🤣 |
|
@wbpcode it's not mandatory, but I think it would be better to pass the parameter explicitly in the call sites to indicate that access log type is irrelevant or not handled in those cases. Practically this is just a refactor, no behavioral changes here. I've done the same with #27034. The reason for using the default value in first place, was to reduce the number of changes in the actual feature PR, so it can be reviewed more easily (otherwise it would have 2000+ changed lines instead of 800).. |
|
got it. defer this pr to @adisuissa and @yanavlasov because #27034 was reviewed by them. And thanks for this contribution. 😺 |
yanavlasov
approved these changes
May 1, 2023
michaelfinch
added a commit
to michaelfinch/envoy
that referenced
this pull request
May 2, 2023
* main: (175 commits) xds: add config for pick_first LB policy extension (envoyproxy#26952) ci: run Kotlin tests with signal_trace disabled (envoyproxy#27090) ssl: upgrade FIPS boringssl version (envoyproxy#27087) Add createPath to Filesystem abstraction. (envoyproxy#27052) mobile/ci: Increase test_timeout for ios tests (envoyproxy#27044) [mobile]remove Java and GMScore impl from Cronvoy (envoyproxy#27039) Fix compliance issues for iOS builds (envoyproxy#27027) docs: fix the license URL of the dependency "dd-trace-cpp" (envoyproxy#27054) ci/mobile: Hide CI progress in .bazelrc (envoyproxy#27045) thrift_proxy: add access log support for local reply (envoyproxy#27057) ci: Consolidate artifact targets (envoyproxy#27079) lb: moving maglev to extensions (envoyproxy#27037) Overload Manager: LoadShedPoint for HCM decode headers (envoyproxy#26769) Plumb ServerFactoryContext into header validator factory (envoyproxy#27008) access_log: use AccessLogType::NotSet instead of default value (envoyproxy#27058) access_log: pass access log type parameter to evaluate function (envoyproxy#27063) Remove unused member from GrpcStream (envoyproxy#27055) tools: setup build in local_fix_format (envoyproxy#27060) generic proxy: virtual host support for the generic proxy routing (envoyproxy#26932) deps: Bump pytooling publishing deps (envoyproxy#27059) ...
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
…proxy#27058) * use AccessLogType::NotSet instead of default parameter value * pass access log type parameter in wasm extension Signed-off-by: ohadvano <ohadvano@gmail.com> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: access_log: use AccessLogType::NotSet instead of default value
Additional Description: Remove default value for the access_log_type parameter in any log function and instead call log() with AccessLogType::NotSet to explicitly indicate that the access log type is irrelevant or not handled
Risk Level: Low
Testing: Unit tests
Docs Changes: None
Release Notes: None
Platform Specific Features: None