Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext_proc fuzzer test exposed a race issue which leads to ENVOY_BUG #27639

Merged
merged 7 commits into from
Jun 2, 2023
Merged

ext_proc fuzzer test exposed a race issue which leads to ENVOY_BUG #27639

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f1f246e
ext_proc fuzzer test exposed a race issue which leads to ENVOY_BUG in…
yanjunxiang-google May 25, 2023
8e9d5e5
Merge branch 'main' of https://github.com/envoyproxy/envoy into open_…
yanjunxiang-google May 30, 2023
0ebd8c7
Merge branch 'main' of https://github.com/envoyproxy/envoy into open_…
yanjunxiang-google May 30, 2023
3bfe644
adding stream_ check
yanjunxiang-google May 31, 2023
7e3f10b
addressing comments
yanjunxiang-google May 31, 2023
595f038
ENVOY_LOG
yanjunxiang-google Jun 2, 2023
4bea75d
addressing comments
yanjunxiang-google Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions source/extensions/filters/http/ext_proc/ext_proc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,16 @@ void Filter::setEncoderFilterCallbacks(Http::StreamEncoderFilterCallbacks& callb
}

Filter::StreamOpenState Filter::openStream() {
ENVOY_BUG(!processing_complete_, "openStream should not have been called");
// If processing already completes, no need to open a gRPC stream.
if (processing_complete_) {
yanjunxiang-google marked this conversation as resolved.
Show resolved Hide resolved
// Stream failed while starting and either onGrpcError or onGrpcClose was already called
return sent_immediate_response_ ? StreamOpenState::Error : StreamOpenState::IgnoreError;
}
if (!stream_) {
ENVOY_LOG(debug, "Opening gRPC stream to external processor");
stream_ = client_->start(*this, grpc_service_, decoder_callbacks_->streamInfo());
stats_.streams_started_.inc();
if (processing_complete_) {
// Stream failed while starting and either onGrpcError or onGrpcClose was already called
return sent_immediate_response_ ? StreamOpenState::Error : StreamOpenState::IgnoreError;
}

yanjunxiang-google marked this conversation as resolved.
Show resolved Hide resolved
// For custom access logging purposes. Applicable only for Envoy gRPC as Google gRPC does not
// have a proper implementation of streamInfo.
if (grpc_service_.has_envoy_grpc()) {
Expand Down
70 changes: 70 additions & 0 deletions ...tp/ext_proc/unit_test_fuzz/ext_proc_corpus/crash-232906f11069ff930e29c13c1a3ae5a2c3202c57
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.