upstream: make upstream_bind_config work in udp upstream #30970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing implementation of UDP upstream did not make use of the upstream_bind_config. I modified the UDP Upstream code to check whether the bind config is specified and set the local address and socket option accordingly. Signed-off-by: Jeongseok Son <jeongseok.son@gmail.com>
|
Hi Ryan, can I ask you to review the code since you reviewed the previous connect-udp PRs? Thank you. |
|
/wait on CI |
Signed-off-by: Jeongseok Son <jeongseok.son@gmail.com>
|
/retest |
Signed-off-by: Jeongseok Son <jeongseok.son@gmail.com>
RyanTheOptimist
approved these changes
Nov 20, 2023
|
/assign @lizan |
lizan
approved these changes
Nov 21, 2023
|
Thanks all for reviewing the PR! Can any of you initiate the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
The existing implementation of UDP upstream did not make use of the upstream_bind_config. I modified the UDP Upstream code to check whether the bind config is specified and set the local address and socket option accordingly.
Additional Description:
Risk Level: Low, this is a bug fix.
Testing: Added unit tests covering added code.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A