Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exceptions : normalizing 3 more exceptions #31088

Merged
merged 1 commit into from
Nov 29, 2023
Merged

exceptions : normalizing 3 more exceptions #31088

merged 1 commit into from
Nov 29, 2023

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Nov 28, 2023 •
edited
Loading

moving ProtoValidationException, MissingFieldException OutOfRangeException to EnvoyException

Additional Description:
Risk Level: low
Testing: updated unit tests
Docs Changes: n/a
Release Notes: n/a

#30857

@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #31088 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk force-pushed the move_exception branch 2 times, most recently from f061e9c to 1d5ea12 Compare November 28, 2023 20:25
@alyssawilk
Copy link
Contributor Author

/retest

@alyssawilk
Copy link
Contributor Author

/retest

@alyssawilk alyssawilk force-pushed the move_exception branch 2 times, most recently from 7feefd9 to cfde9f9 Compare November 29, 2023 13:38
@alyssawilk
normalizing exceptions
5e3dde4 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @RyanTheOptimist

🐱

Caused by: #31088 was synchronize by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk marked this pull request as ready for review November 29, 2023 16:34
@alyssawilk
Copy link
Contributor Author

Ryan you're just on the hook for "code was removed so coverage went down" - feel free to recuse after checking that.

RyanTheOptimist
RyanTheOptimist reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage changes LGTM

@alyssawilk alyssawilk merged commit b19956a into envoyproxy:main Nov 29, 2023
105 checks passed
@alyssawilk alyssawilk deleted the move_exception branch March 19, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanTheOptimist RyanTheOptimist RyanTheOptimist left review comments

@zuercher zuercher zuercher approved these changes

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

@wbpcode wbpcode Awaiting requested review from wbpcode wbpcode is a code owner

Assignees

@zuercher zuercher

@RyanTheOptimist RyanTheOptimist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alyssawilk @zuercher @RyanTheOptimist