Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-ares: add option for udp_max_queries #33551

Merged
merged 14 commits into from
Apr 29, 2024

update api ref

392cc7e
Select commit
Loading
Failed to load commit list.
Merged

c-ares: add option for udp_max_queries #33551

update api ref
392cc7e
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/CC succeeded Apr 29, 2024 in 2m 53s

Mobile/CC (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Mobile/CC (pr/33551/main@392cc7e)

Check started by

Request (pr/33551/main@392cc7e)

deveshkandpal1224 @deveshkandpal1224 392cc7e #33551 merge main@81c6142

c-ares: add option for udp_max_queries

Commit Message: Provides an option to set udp_max_queries in DNSResolverOptions to limit max UDP queries.
Additional Description: This change does following:

  • Implements the fix in this version of c-ares library that has been raised in this comment.
  • Updates c-ares library to 1.20 to get access to the required change in the library.
  • Updates resolver.proto to expose the option to pass udp_max_queries which can then be passed to c-ares.
  • Updates dirty_channel status check logic to conditionally check for status == ARES_EREFUSED without which DestroyChannelOnRefused and CustomResolverValidAfterChannelDestruction test fail after upgrading the c-ares library to 1.20
  • Adds a unit test to validate that when udp_max_queries is set, ARES_OPT_UDP_MAX_QUERIES flag is set as well.

Risk Level: Low
Testing: Unit test
Docs Changes: n/a
Release Notes: updated
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Environment

Request variables

Key Value
ref dceddcb
sha 392cc7e
pr 33551
base-sha 81c6142
actor deveshkandpal1224 @deveshkandpal1224
message c-ares: add option for udp_max_queries...
started 1714356327.489532
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 31
patch 0
dev true