xds-failover: plumb the API and the mux to the failover #34417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
|
/retest |
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
htuch
pushed a commit
that referenced
this pull request
Jun 4, 2024
This is a breakdown of #34417 to multiple PRs. In this PR we introduce the envoy.restart_features.xds_failover_support runtime flag which defaults to false. We also modify the legacy GrpcMux SotW and Delta implementations to use the GrpcMuxFailover object instead of the GrpcStream object when the runtime flag is set to true. Next is updating the Unified Sotw/Delta GrpcMux implementation, and plumbing the API through to use the xDS-Failover. Risk Level: medium if the runtime flag is set to true. Testing: Updated the test cases (parameterized). Signed-off-by: Adi Suissa-Peleg <adip@google.com>
htuch
pushed a commit
that referenced
this pull request
Jun 6, 2024
This PR introduces xDS-Failover support for unified gRPC mux implementations. This is similar to #34437, and another part of #34417. Risk Level: medium if the runtime flag is set to true and unified-gRPC-mux is used. Testing: Updated the test cases (parameterized). Signed-off-by: Adi Suissa-Peleg <adip@google.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
Last relevant PR: #34761. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: xds-failover: plumb the API and the mux to the failover
Additional Description:
Plumbing the failover support to the API and the different GrpcMux objects.
The biggest change here is that the GrpcMux objects use the GrpcMuxFailover object instead of the GrpcStream object.
Note that this feature is guarded by
envoy.restart_features.xds_failover_supportwhich is false by default, and without setting it to true the GrpcStream will be used directly.Risk Level: medium - but guarded and false by default.
Testing: Added unit and integration tests.
Docs Changes: N/A - will add once the feature is out of alpha
Release Notes: N/A - will add once the feature is out of alpha