Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bazel configuration ambiguity for non HTTP3 builds #34483

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Fixed bazel configuration ambiguity for non HTTP3 builds #34483

merged 3 commits into from
Jun 6, 2024

Commits on Jun 3, 2024

  1. Fixed bazel configuration ambiguity for non HTTP3 builds 

    To avoid ambiguity when building with //bazel:http3=False (on PPC
and Windows) this commit adds 2 new config_setting_groups and
updates the relevant select() statements.

Signed-off-by: Ted Poole <tpoole@redhat.com>
    @tedjpoole
    tedjpoole committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d910a0e View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Fixed bazel configuration ambiguity for non HTTP3 builds 

    My first commit didn't really fix anything.
This commit completes the fix.

Signed-off-by: Ted Poole <tpoole@redhat.com>
    @tedjpoole
    tedjpoole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    791b1f6 View commit details
    Browse the repository at this point in the history

  2. Simplified the names of always_{true|false}_flag 

    Signed-off-by: Ted Poole <tpoole@redhat.com>
    @tedjpoole
    tedjpoole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    88cb8f3 View commit details
    Browse the repository at this point in the history