Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscription: making exception free #34554

Merged
merged 1 commit into from
Jun 6, 2024
Merged

subscription: making exception free #34554

merged 1 commit into from
Jun 6, 2024

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Jun 5, 2024 •
edited
Loading

Risk Level: low
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176

@alyssawilk
subscription: making exception free
49e74fd 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34554 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk marked this pull request as ready for review June 5, 2024 15:26
@alyssawilk alyssawilk merged commit db9d7ea into envoyproxy:main Jun 6, 2024
51 of 52 checks passed
@zirain zirain mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbpcode wbpcode wbpcode approved these changes

Assignees

@wbpcode wbpcode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssawilk @wbpcode