[balsa] Disallow CR not followed by LF in header values. #34829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the behavior of BalsaParser consistent with that of http-parser. Signed-off-by: Bence Béky <bnc@google.com>
|
/retest |
|
/assign @yanavlasov |
Signed-off-by: Bence Béky <bnc@google.com>
Signed-off-by: Bence Béky <bnc@google.com>
yanavlasov
approved these changes
Jun 24, 2024
|
/retest |
Signed-off-by: Bence Béky <bnc@google.com>
Signed-off-by: Bence Béky <bnc@google.com>
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Jul 2, 2024
…oyproxy#34829)" This reverts commit f15ec82. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…34829) This makes the behavior of BalsaParser consistent with that of http-parser. Signed-off-by: Bence Béky <bnc@google.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…34829) This makes the behavior of BalsaParser consistent with that of http-parser. Signed-off-by: Bence Béky <bnc@google.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…34829) This makes the behavior of BalsaParser consistent with that of http-parser. Signed-off-by: Bence Béky <bnc@google.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…34829) This makes the behavior of BalsaParser consistent with that of http-parser. Signed-off-by: Bence Béky <bnc@google.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: [balsa] Disallow CR not followed by LF in header values.
Additional Description: This makes the behavior of BalsaParser consistent with that of http-parser.
Risk Level: low
Testing: //test/common/http/http1:codec_impl_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a