Docs: add_user_agent option needs to be set for x-envoy-downstream-cluster scenarios #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,7 +48,8 @@ external requests, but for internal requests will contain the service cluster of | |||
| that in the current implementation, this should be considered a hint as it is set by the caller and | |||
| could be easily spoofed by any internal entity. In the future Envoy will support a mutual | |||
| authentication TLS mesh which will make this header fully secure. Like *user-agent*, the value | |||
| is determined by the :option:`--service-cluster` command line option. | |||
| is determined by the :option:`--service-cluster` command line option. In order to enable this | |||
| feature you need to set :ref:`user_agent <config_http_conn_man_add_user_agent>` option to true. | |||
There was a problem hiding this comment.
"the user_agent option..."
mattklein123
approved these changes
Jan 24, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* ApiManager handles managed rollout_strategy * Fixed code formatting * ConfigManager ignores the rollout when download was not successful * Revert "ConfigManager ignores the rollout when download was not successful" This reverts commit f6de9be8b2c9c25d8f62f56cb8c31a6b7602e0fb. * Removed const directive
jplevyak
added a commit
to jplevyak/envoy
that referenced
this pull request
Jan 22, 2020
Update ABI WRT Architecture doc and comments from upstreaming.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: add tighter timeouts to CI than the default 360 mins. Risk Level: low Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: add tighter timeouts to CI than the default 360 mins. Risk Level: low Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.