Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upstream: outlier detector - distinguish upstream from internal errors #4822

Merged
merged 59 commits into from
Jun 27, 2019
Merged

upstream: outlier detector - distinguish upstream from internal errors #4822

merged 59 commits into from
Jun 27, 2019

Commits on Oct 22, 2018

  1. Outlier detector: connection failures are handled separately from 5xx… 

    … errors.

Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    5530d11 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue/3643 

    Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    44d815b View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2018

  1. Fixed test directory compile problems after rebase. 

    Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    09bba39 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2018

  1. Outlier detector: 

     - removed mapping connect and server transactions errors to HTTP codes.
 - changed tcp_proxy and redis proxy to use connect errors and
   server transactions errors.

Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    9784ddd View commit details
    Browse the repository at this point in the history

  2. Corrected unit tests to use new API to outlier detector. 

    Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    f0a8660 View commit details
    Browse the repository at this point in the history

  3. Corrected tcp_proxy unit test to use new outlier detector API. 

    Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    1954b03 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2018

  1. - Added separate Success Rate monitor for local origin errors. 

    - Separated local origin errors from extarnal errors for consecutive counters.

Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    535cddc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    cab57f3 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2018

  1. Updated docs to reflect separation of local origin and external origin 

    errors in outlier detection logic.

Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    41fbe26 View commit details
    Browse the repository at this point in the history

  2. Corrected spelling errors and compile errors. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    af046e2 View commit details
    Browse the repository at this point in the history

  3. Corrected docs formatting. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    9e6ca10 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    fcd5ec7 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. Changes after code review: 

     - added const for read only data and methods
 - wrapped average success rate and threashold into Ejectionpair struct

Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    fea1434 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2019

  1. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    0fe3d1b View commit details
    Browse the repository at this point in the history

  2. Run formatting tool. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    3c6a0f9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    6ed3be2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    b820bf4 View commit details
    Browse the repository at this point in the history

  5. Corrected spelling mistakes. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    551275f View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2019

  1. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    7484049 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2019

  1. Added split_external_local_origin_error config parameter. If enebled 

    local origin and external origin errors will be treated separately
by outlier detector.

Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    61a298c View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    420eab0 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Bring code to required functionality after the rebase from master. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    91c256f View commit details
    Browse the repository at this point in the history

  2. Corrected unit test to match code logic. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    2edef1c View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2019

  1. Updated documentation after PR review. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    18a42ed View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    c41fb86 View commit details
    Browse the repository at this point in the history

  3. Added release note. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    93fa804 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2019

  1. Corrected format in release notes. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    0c09aa4 View commit details
    Browse the repository at this point in the history

  2. Converted new redis unit test cases to use new API to outlier detector. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    00c8289 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2019

  1. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    e8cc31c View commit details
    Browse the repository at this point in the history

  2. After rebase: 

    Adjusted unit tests to use new API to outlier detector.

Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    6fb5367 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. Updated documentation after code review. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    2217d99 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. Changed back to use enum to distinguish localOrigin and externalOrigin 

    success rate monitors.

Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 3, 2019
    Configuration menu
    Copy the full SHA
    8fa84b9 View commit details
    Browse the repository at this point in the history

  2. Small style corrections after code review. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 3, 2019
    Configuration menu
    Copy the full SHA
    10cdab0 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. Removed hash tables storing success rate monitors and numbers and 

    replaced with simple if..else methods.

Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 4, 2019
    Configuration menu
    Copy the full SHA
    6c3d55a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 4, 2019
    Configuration menu
    Copy the full SHA
    5d24bb0 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2019

  1. Changed DetectorHostMonitor::SuccessRateMonitorType enum to be scoped. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 7, 2019
    Configuration menu
    Copy the full SHA
    c0cc0e3 View commit details
    Browse the repository at this point in the history

  2. Small style changes: use snake case for variable names. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 7, 2019
    Configuration menu
    Copy the full SHA
    9234892 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 7, 2019
    Configuration menu
    Copy the full SHA
    4ba5f89 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. Corrections after code review: 

      - Updated docs describing log types for each ejetion type
  - Changed ejetion type from SUCCESS_RATE_EXTERNAL_ORIGIN to SUCCESS_RATE

Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 10, 2019
    Configuration menu
    Copy the full SHA
    5fe4bc0 View commit details
    Browse the repository at this point in the history

  2. Updated description for CONSECUTIVE_LOCAL_ORIGIN_FAILURE log type. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 10, 2019
    Configuration menu
    Copy the full SHA
    6301eab View commit details
    Browse the repository at this point in the history

Commits on May 14, 2019

  1. Added comments after code review. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 14, 2019
    Configuration menu
    Copy the full SHA
    8e0641b View commit details
    Browse the repository at this point in the history

Commits on May 16, 2019

  1. Renamed outlier detector's non-http events to contain prefix indicating 

    whether it is local or external origin event.

Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 16, 2019
    Configuration menu
    Copy the full SHA
    9703454 View commit details
    Browse the repository at this point in the history

  2. Removed __attribute__((fallthrough)) statement as it was causing 

    compile error.

Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 16, 2019
    Configuration menu
    Copy the full SHA
    8e3aea0 View commit details
    Browse the repository at this point in the history

  3. Fixed compile error. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 16, 2019
    Configuration menu
    Copy the full SHA
    eaaff40 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 17, 2019
    Configuration menu
    Copy the full SHA
    0707339 View commit details
    Browse the repository at this point in the history

  2. Added several tests to bring coverage to ~100%. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 17, 2019
    Configuration menu
    Copy the full SHA
    9792f90 View commit details
    Browse the repository at this point in the history

  3. Added comment to test case. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 17, 2019
    Configuration menu
    Copy the full SHA
    3840f6d View commit details
    Browse the repository at this point in the history

Commits on May 22, 2019

  1. Removed complicated logic of not mappoing LOCAL_ORIGIN_CONNECT_SUCCESS 

    from internals of outlier detector and moved that logic to individual
filters.

Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 22, 2019
    Configuration menu
    Copy the full SHA
    ec44238 View commit details
    Browse the repository at this point in the history

  2. Fixed format issue. 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 22, 2019
    Configuration menu
    Copy the full SHA
    43f69b6 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 28, 2019
    Configuration menu
    Copy the full SHA
    4216f8e View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 29, 2019
    Configuration menu
    Copy the full SHA
    cd69579 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue/3643 

    Signed-off-by: Christopher Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed May 29, 2019
    Configuration menu
    Copy the full SHA
    08584ba View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2019

  1. Merge branch 'master' into issue/3643 

    Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    feed828 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. Added new code for local origin errors to indicate that there is no 

    other protocol which will report final transaction error.

Refactored putResult method to avoid hacking some scenarios with
non-enum values.

Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    30fa5c7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue/3643 

    Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    e8e9b1c View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. Merge branch 'master' into issue/3643 

    Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    a5c251a View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. Style corrections after code review. 

    Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    e85f07a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue/3643 

    Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    d91fb30 View commit details
    Browse the repository at this point in the history

  3. Changed successRate method to be const. 

    Adjusted unit tests after rebase from master.

Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
    @cpakulski
    cpakulski committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    0049372 View commit details
    Browse the repository at this point in the history