hot restart: block new starts if previous process is still initializing #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lyft/network-team @kyessenov can you please test this PR and let me know if it fixes your issue. |
|
I have trouble reproducing the race reliably. We run the fast restart on each pre-submit, so I can let you know if I this happens again after merge. |
|
@kyessenov deploying a change like this at Lyft is kind of a pain. I would really like to know if this fixes your issue, and you are going to have to write code around it also to handle the error case. Isn't there some way you can test this locally? |
|
@kyessenov has confirmed fix. @lyft/network-team please review. |
RomanDzhabarov
approved these changes
Mar 10, 2017
ccaraman
reviewed
Mar 10, 2017
| @@ -53,6 +53,16 @@ SharedMemory& SharedMemory::initialize(Options& options) { | |||
| RELEASE_ASSERT(shmem->version_ == VERSION); | |||
| } | |||
|
|
|||
| // Here we catch the case where a new Envoy starts up when the current Envoy has not yet fully | |||
| // initialized. The startup logic is quite compicated, and it's not worth trying to handle this | |||
There was a problem hiding this comment.
will fix in follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #550