Build: Fix unit test cert generation (#704) #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The temporary SSL certificates used for test/common/ssl unit tests were being generated by a Bazel build rule. However, this meant that unless they were missing they were not regenerated. This wasn't really appropriate for the unit test use case since the unit test verifying expiration had expectations about the SSL certificate being generated less than one day before the test ran. Ultimately this resulted in Issue 704 where Bazel builds failed the test if it had been more than 24 hours since the last clean. To fix this the ephemeral certificates used by the unit tests are generated immediately prior to running the test and placed into the Bazel temp directory to be consumed by the test.
mattklein123
approved these changes
Apr 8, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
…envoyproxy#704)" (envoyproxy#723) Trying to fix post-submit failure This reverts commit c04ec87.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Revert "Strip out "spiffe://" in the identity (envoyproxy#719)" This reverts commit 99a482f. * Revert "Revert "Remove -release in filename when doing release build of proxy (envoyproxy#704)" (envoyproxy#723)" This reverts commit 13669ce. * Revert "Not to send legacy quota for v2 config. (envoyproxy#722)" This reverts commit aaf25ca.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The temporary SSL certificates used for test/common/ssl unit tests
were being generated by a Bazel build rule. However, this meant that
unless they were missing they were not regenerated. This wasn't really
appropriate for the unit test use case since the unit test verifying
expiration had expectations about the SSL certificate being generated
less than one day before the test ran. Ultimately this resulted in Issue
704 where Bazel builds failed the test if it had been more than 24 hours
since the last clean.
To fix this the ephemeral certificates used by the unit tests are
generated immediately prior to running the test and placed into the
Bazel temp directory to be consumed by the test.