Run flake8 on Python instead of legacy Python #7388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
run-flake8-on-Python
branch
4 times, most recently
from
b36795f
to
9a97262
Compare
htuch
reviewed
Jun 24, 2019
|
|
||
| echo "Running Python3 flake8 check..." | ||
| flake8 . --exclude=*/venv/* --count --select=E901,E999,F821,F822,F823 --show-source --statistics | ||
| python3 -m flake8 --version | ||
| python3 -m flake8 . --exclude=*/venv/* --count --select=E9,F63,F72,F82 --show-source --statistics |
There was a problem hiding this comment.
Are we preserving semantics here (roughly)?
There was a problem hiding this comment.
Yes. This is a superset of the previous tests: E9 runs all E9xx tests and F82 runs all F82x tests. We are forcing flake8 to run on Python 3 because it has a stricter syntax than legacy Python.
|
@cclauss this is failing the format check, can you take a look? |
|
@cclauss ideally put PRs into a draft status in this situation, it makes it easier to track what's ready for review, see https://github.blog/2019-02-14-introducing-draft-pull-requests/. |
Signed-off-by: cclauss <cclauss@me.com>
Signed-off-by: cclauss <cclauss@me.com>
cclauss
force-pushed
the
run-flake8-on-Python
branch
from
5fd5ac7
to
5093561
Compare
|
/wait |
Signed-off-by: cclauss <cclauss@me.com>
cclauss
force-pushed
the
run-flake8-on-Python
branch
from
6ba130a
to
92f85b3
Compare
|
@cclauss I think the ask was to do this in the commit, I'll do that when I merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by:
#7383, #7384, and #7385Related to: #4552
Signed-off-by: cclauss cclauss@me.com
Also adds more critical flake8 tests.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]