Patch in ecf04cc and 49f0fb9 from gRPC. #7850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix #7835 too? |
|
Can you add a patch for #7835 as well? That’s a breakage coming sooner. |
|
Done. It's not merged yet, but I guess that's OK? |
This is so that Envoy keeps building with the --incompatible_disable_legacy_proto_provider command line option of Bazel which is to be flipped in 1.0 . Signed-off-by: Lukacs T. Berki <lberki@google.com>
Signed-off-by: Lukacs T. Berki <lberki@google.com>
Signed-off-by: Lukacs T. Berki <lberki@google.com>
|
Paperwork complete! |
lizan
approved these changes
Aug 9, 2019
|
Gentle ping! This fixes a breakage in the coming-very-soon Bazel 0.29. |
|
@lberki we just had a security release today, I was holding this change and will merge later today. |
|
Thank you! I verified that this fixes the potential breakage, so I'll submit our flag flip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that Envoy keeps building with the --incompatible_disable_legacy_proto_provider command line option of Bazel which is to be flipped in 1.0 .
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]