-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lua: Allow to set header entry as table to httpCall and respond APIs #7851
Conversation
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
@mattklein123 do we want to return header values of the same header entry key as a table when we do |
I'm concerned this might break existing scripts? WDYT? Perhaps we don't do it for now or provide some type of API ability to return it this way? |
@dio please let me know when this is no longer WIP. Thank you! /wait |
@mattklein123 yes, think this is ready for review. Thank you! While for getting multiple values from a header name can be done via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small nit. Thank you!
/wait
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Oops. Accepting suggestion hurts DCO. Did force pushing. Sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM post security release
Description: Extends
httpCall()
andrespond()
APIs to accept headers with values that can be strings or table of strings.Risk Level: Low
Testing: Modified the existing unit tests
Docs Changes: Added
Release Notes: Added
Fixes #7742
Signed-off-by: Dhi Aurrahman dio@tetrate.io