Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: fully validating terminal filter ordering for L4 #7904

Merged
merged 3 commits into from
Aug 14, 2019

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Aug 13, 2019

Follow up on #7779
envoyproxy/envoy-filter-example#96
to finish filter order validation.

Risk Level: Low (Enovy will now reject invalid configs)
Testing: new UT
Docs Changes: n/a
Release Notes: n/a

@mattklein123 mattklein123 self-assigned this Aug 13, 2019
Signed-off-by: Alyssa Wilk <alyssar@google.com>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@google.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mattklein123 mattklein123 merged commit b2719f6 into envoyproxy:master Aug 14, 2019
@alyssawilk alyssawilk deleted the terminalv2 branch December 9, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants