Dependency: Update rules_go, Go, Python, curl, bazel-toolchains, bazelisk #7934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Payne <michael@sooper.org>
Signed-off-by: Michael Payne <michael@sooper.org>
lizan
suggested changes
Aug 15, 2019
WORKSPACE
Outdated
| @@ -15,3 +15,29 @@ envoy_dependencies() | |||
| load("//bazel:dependency_imports.bzl", "envoy_dependency_imports") | |||
|
|
|||
| envoy_dependency_imports() | |||
|
|
|||
| load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies", "go_repository") | |||
There was a problem hiding this comment.
roll them into envoy_dependency_imports.
There was a problem hiding this comment.
@lizan I think I've done what you were suggesting. Local test, api build and format check look OK. Let me know if you were thinking of something different.
Signed-off-by: Michael Payne <michael@sooper.org>
lizan
approved these changes
Aug 15, 2019
|
CI showing |
|
FWIW: macos CI passed but GH doesn't reflect https://dev.azure.com/cncf/envoy/_build/results?buildId=8456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Payne michael@sooper.org
Description: Update dependencies:
org_golang_google_grpcis no longer declared ingo_rules_dependencies. In order for the API to build, changes toWORKSPACEoutlined here are required. This pollutesWORKSPACEwith some dependencies. Open on ways to improve this.Risk Level: Low
Testing:
./docs/build.sh,bazel build @envoy_api//envoy/...,bazel test //test/...Docs Changes: None required
Release Notes: None required