-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: adding an option to hard-fail when deprecated config is used. #7962
Changes from 5 commits
9fae5a9
8c6d2b8
a427a9c
f9d670c
5829dd5
4e0bb5e
7461005
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -492,6 +492,7 @@ TEST_F(DeprecatedFieldsTest, NoErrorWhenDeprecatedFieldsUnused) { | |
EXPECT_EQ(0, runtime_deprecated_feature_use_.value()); | ||
} | ||
|
||
#ifndef ENVOY_DISABLE_DEPRECATED_FEATURES | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we expect the number of test need this guard grow or spread when we have more deprecated fields? If so probably worth adding a macro
The macro adds There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unclear - this is what we have for the 13 currently deprecated fields, and most off the disabling is actually just for the overall runtime functionality. I like the idea of the macro though - seems cleaner and easier to see what's disabled. |
||
TEST_F(DeprecatedFieldsTest, IndividualFieldDeprecated) { | ||
envoy::test::deprecation_test::Base base; | ||
base.set_is_deprecated("foo"); | ||
|
@@ -617,6 +618,7 @@ TEST_F(DeprecatedFieldsTest, RepeatedMessageDeprecated) { | |
"'envoy.test.deprecation_test.Base.deprecated_repeated_message'", | ||
MessageUtil::checkForDeprecation(base)); | ||
} | ||
#endif | ||
|
||
class TimestampUtilTest : public testing::Test, public ::testing::WithParamInterface<int64_t> {}; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,7 +36,9 @@ const std::string& testConfig() { | |
name: envoy.redis_proxy | ||
config: | ||
stat_prefix: redis_stats | ||
cluster: cluster_0 | ||
prefix_routes: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Q: are we losing coverage of the deprecated paths here and below with this change? Should these tests instead be wrapped or do we need additional tests? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can add unit tests for the old route / cors logic. Ok if I do it in a follow-up? I'd like to land this sooner rather than later, just so I don't have to do more test fix up :-) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure sounds good. |
||
catch_all_route: | ||
cluster: cluster_0 | ||
settings: | ||
op_timeout: 5s | ||
clusters: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update this description.