Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf: towards unifying PGV, deprecated and unknown field validation. #8002

Merged
merged 2 commits into from
Aug 22, 2019
Merged

protobuf: towards unifying PGV, deprecated and unknown field validation. #8002

merged 2 commits into from
Aug 22, 2019

Commits on Aug 22, 2019

  1. protobuf: towards unifying PGV, deprecated and unknown field validation. 

    This is part of envoyproxy#7980; basically, we want to leverage the recursive pass
that already exists for the deprecated check. This PR does not implement
the recursive behavior yet for unknown fields though, because there is a
ton of churn, so this PR just has the mechanical bits. We switch
plumbing of validation visitor into places such as anyConvert() and
instead pass this to MessageUtil::validate.

There are a bunch of future followups planned in additional PRs:
* Combine the recursive pass for unknown/deprecated check in
  MessageUtil::validate().
* Add mitigation for envoyproxy#5965 by copying to a temporary before recursive
  expansion.
* [Future] consider moving deprecated reporting into a message
  validation visitor handler.

Risk level: Low
Testing: Some new //test/common/protobuf::utility_test unit test.

Signed-off-by: Harvey Tuch <htuch@google.com>
    @htuch
    htuch committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    aa4b45c View commit details
    Browse the repository at this point in the history

  2. Tag envoyproxy#8010 ingRPC metadata creds. 

    Signed-off-by: Harvey Tuch <htuch@google.com>
    @htuch
    htuch committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    ff07f57 View commit details
    Browse the repository at this point in the history