Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy: misc-unused-using-decls #8159

Merged
merged 5 commits into from
Sep 6, 2019
Merged

clang-tidy: misc-unused-using-decls #8159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b3cda7a
clang-tidy: misc-unused-using-decls
derekargueta Sep 5, 2019
07666cf
Fix build
derekargueta Sep 5, 2019
ead9609
add decls to dictionary
derekargueta Sep 5, 2019
03cdc0f
add missing close-parenthesis
derekargueta Sep 5, 2019
b3d35d2
build fix - a missing using
derekargueta Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ Checks: 'abseil-*,
bugprone-*,
clang-analyzer-*,
clang-diagnostic-*,
misc-unused-using-decls,
modernize-*,
performance-*,
readability-braces-around-statements,
Expand All @@ -20,6 +21,7 @@ WarningsAsErrors: 'abseil-duration-*,
bugprone-unused-raii,
bugprone-use-after-move,
clang-analyzer-core.DivideZero,
misc-unused-using-decls,
modernize-deprecated-headers,
modernize-loop-convert,
modernize-make-shared,
Expand Down
2 changes: 0 additions & 2 deletions source/extensions/filters/http/grpc_json_transcoder/json_transcoder_filter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
#include "grpc_transcoding/path_matcher_utility.h"
#include "grpc_transcoding/response_to_json_translator.h"

using Envoy::Protobuf::DescriptorPool;
using Envoy::Protobuf::FileDescriptor;
using Envoy::Protobuf::FileDescriptorSet;
using Envoy::Protobuf::io::ZeroCopyInputStream;
using Envoy::ProtobufUtil::Status;
Expand Down
1 change: 0 additions & 1 deletion test/common/access_log/access_log_formatter_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "gmock/gmock.h"
#include "gtest/gtest.h"

using testing::_;
using testing::Const;
using testing::NiceMock;
using testing::Return;
Expand Down
3 changes: 2 additions & 1 deletion test/common/config/filesystem_subscription_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
#include "gmock/gmock.h"
#include "gtest/gtest.h"

using ::testing::Throw;
using testing::Return;
using testing::Throw;

namespace Envoy {
namespace Config {
Expand Down
1 change: 0 additions & 1 deletion test/common/config/filesystem_subscription_test_harness.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

using testing::_;
using testing::NiceMock;
using testing::Return;

namespace Envoy {
namespace Config {
Expand Down
2 changes: 0 additions & 2 deletions test/common/config/rds_json_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
#include "gmock/gmock.h"
#include "gtest/gtest.h"

using testing::_;

namespace Envoy {
namespace Config {
namespace {
Expand Down
2 changes: 0 additions & 2 deletions test/common/config/utility_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,8 @@
#include "gtest/gtest.h"

using testing::_;
using testing::AtLeast;
using testing::Ref;
using testing::Return;
using testing::ReturnRef;

namespace Envoy {
namespace Config {
Expand Down
2 changes: 0 additions & 2 deletions test/common/event/dispatcher_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
using testing::_;
using testing::InSequence;
using testing::NiceMock;
using testing::Return;
using testing::StartsWith;

namespace Envoy {
namespace Event {
Expand Down
1 change: 0 additions & 1 deletion test/common/grpc/async_client_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ using testing::Eq;
using testing::Invoke;
using testing::Return;
using testing::ReturnRef;
using testing::Throw;

namespace Envoy {
namespace Grpc {
Expand Down
1 change: 0 additions & 1 deletion test/common/http/async_client_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
using testing::_;
using testing::Invoke;
using testing::NiceMock;
using testing::Ref;
using testing::Return;
using testing::ReturnRef;

Expand Down
2 changes: 0 additions & 2 deletions test/common/http/codec_client_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ using testing::InvokeWithoutArgs;
using testing::NiceMock;
using testing::Pointee;
using testing::Ref;
using testing::Return;
using testing::SaveArg;
using testing::Throw;

namespace Envoy {
Expand Down
1 change: 0 additions & 1 deletion test/common/http/codes_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "gmock/gmock.h"
#include "gtest/gtest.h"

using testing::_;
using testing::Property;

namespace Envoy {
Expand Down
2 changes: 0 additions & 2 deletions test/common/http/conn_manager_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ using testing::_;
using testing::An;
using testing::AnyNumber;
using testing::AtLeast;
using testing::DoAll;
using testing::Eq;
using testing::HasSubstr;
using testing::InSequence;
Expand All @@ -61,7 +60,6 @@ using testing::NiceMock;
using testing::Ref;
using testing::Return;
using testing::ReturnRef;
using testing::Sequence;

namespace Envoy {
namespace Http {
Expand Down
1 change: 0 additions & 1 deletion test/common/http/conn_manager_utility_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

using testing::_;
using testing::An;
using testing::InSequence;
using testing::Matcher;
using testing::NiceMock;
using testing::Return;
Expand Down
1 change: 0 additions & 1 deletion test/common/http/http1/conn_pool_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ using testing::NiceMock;
using testing::Property;
using testing::Return;
using testing::ReturnRef;
using testing::SaveArg;

namespace Envoy {
namespace Http {
Expand Down
1 change: 0 additions & 1 deletion test/common/http/http2/conn_pool_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ using testing::NiceMock;
using testing::Property;
using testing::Return;
using testing::ReturnRef;
using testing::SaveArg;

namespace Envoy {
namespace Http {
Expand Down
1 change: 0 additions & 1 deletion test/common/init/manager_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#include "gtest/gtest.h"

using ::testing::InSequence;
using ::testing::InvokeWithoutArgs;

namespace Envoy {
namespace Init {
Expand Down
2 changes: 0 additions & 2 deletions test/common/json/config_schemas_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
#include "gmock/gmock.h"
#include "gtest/gtest.h"

using testing::_;

namespace Envoy {
namespace Json {
namespace {
Expand Down
1 change: 0 additions & 1 deletion test/common/network/dns_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@

using testing::_;
using testing::InSequence;
using testing::Mock;
using testing::NiceMock;
using testing::Return;

Expand Down
1 change: 0 additions & 1 deletion test/common/network/socket_option_test.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
using testing::_;
using testing::Invoke;
using testing::NiceMock;
using testing::Return;

namespace Envoy {
namespace Network {
Expand Down
2 changes: 0 additions & 2 deletions test/common/router/config_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,12 @@

using testing::_;
using testing::ContainerEq;
using testing::ElementsAreArray;
using testing::Eq;
using testing::Matcher;
using testing::MockFunction;
using testing::NiceMock;
using testing::Return;
using testing::ReturnRef;
using testing::StrNe;

namespace Envoy {
namespace Router {
Expand Down
3 changes: 0 additions & 3 deletions test/common/router/rds_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ using testing::_;
using testing::Eq;
using testing::InSequence;
using testing::Invoke;
using testing::Return;
using testing::ReturnRef;
using testing::SaveArg;

namespace Envoy {
namespace Router {
Expand Down
2 changes: 0 additions & 2 deletions test/common/router/router_ratelimit_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
#include "gmock/gmock.h"
#include "gtest/gtest.h"

using testing::_;
using testing::NiceMock;
using testing::ReturnRef;

namespace Envoy {
namespace Router {
Expand Down
2 changes: 0 additions & 2 deletions test/common/router/router_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,9 @@ using testing::Invoke;
using testing::Matcher;
using testing::MockFunction;
using testing::NiceMock;
using testing::Ref;
using testing::Return;
using testing::ReturnPointee;
using testing::ReturnRef;
using testing::SaveArg;
using testing::StartsWith;

namespace Envoy {
Expand Down
1 change: 0 additions & 1 deletion test/common/router/scoped_config_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ namespace {

using ::Envoy::Http::TestHeaderMapImpl;
using ::testing::NiceMock;
using ::testing::Return;

class FooFragment : public ScopeKeyFragmentBase {
public:
Expand Down
3 changes: 0 additions & 3 deletions test/common/router/scoped_rds_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,12 @@
#include "gtest/gtest.h"

using testing::AnyNumber;
using testing::ByMove;
using testing::DoAll;
using testing::Eq;
using testing::InSequence;
using testing::Invoke;
using testing::IsNull;
using testing::NiceMock;
using testing::Return;
using testing::ReturnRefOfCopy;

namespace Envoy {
namespace Router {
Expand Down
7 changes: 0 additions & 7 deletions test/common/router/vhds_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,6 @@
#include "gmock/gmock.h"
#include "gtest/gtest.h"

using testing::_;
using testing::InSequence;
using testing::Invoke;
using testing::Return;
using testing::ReturnRef;
using testing::SaveArg;

namespace Envoy {
namespace Router {
namespace {
Expand Down
2 changes: 0 additions & 2 deletions test/common/runtime/runtime_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ using testing::Invoke;
using testing::InvokeWithoutArgs;
using testing::NiceMock;
using testing::Return;
using testing::ReturnNew;
using testing::ReturnRef;

namespace Envoy {
namespace Runtime {
Expand Down
1 change: 0 additions & 1 deletion test/common/secret/sds_api_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

using ::testing::_;
using ::testing::Invoke;
using ::testing::Return;

namespace Envoy {
namespace Secret {
Expand Down
3 changes: 0 additions & 3 deletions test/common/stats/stats_matcher_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@

#include "gtest/gtest.h"

using testing::IsFalse;
using testing::IsTrue;

namespace Envoy {
namespace Stats {

Expand Down
1 change: 0 additions & 1 deletion test/common/stats/thread_local_store_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@

using testing::_;
using testing::InSequence;
using testing::Invoke;
using testing::NiceMock;
using testing::Ref;
using testing::Return;
Expand Down
3 changes: 0 additions & 3 deletions test/common/tcp/conn_pool_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,11 @@
#include "gtest/gtest.h"

using testing::_;
using testing::DoAll;
using testing::InSequence;
using testing::Invoke;
using testing::NiceMock;
using testing::Property;
using testing::Return;
using testing::ReturnRef;
using testing::SaveArg;

namespace Envoy {
namespace Tcp {
Expand Down
2 changes: 0 additions & 2 deletions test/common/tracing/http_tracer_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,9 @@

using testing::_;
using testing::Eq;
using testing::Invoke;
using testing::NiceMock;
using testing::Return;
using testing::ReturnPointee;
using testing::ReturnRef;

namespace Envoy {
namespace Tracing {
Expand Down
3 changes: 0 additions & 3 deletions test/common/upstream/cds_api_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,8 @@
#include "gtest/gtest.h"

using testing::_;
using testing::AnyNumber;
using testing::InSequence;
using testing::Invoke;
using testing::Return;
using testing::ReturnRef;
using testing::StrEq;
using testing::Throw;

Expand Down
4 changes: 0 additions & 4 deletions test/common/upstream/cluster_factory_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,7 @@
#include "test/mocks/server/mocks.h"
#include "test/mocks/ssl/mocks.h"

using testing::_;
using testing::ContainerEq;
using testing::Invoke;
using testing::NiceMock;
using testing::ReturnRef;

namespace Envoy {
namespace Upstream {
Expand Down
2 changes: 0 additions & 2 deletions test/common/upstream/cluster_manager_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,8 @@ using testing::InSequence;
using testing::Invoke;
using testing::Mock;
using testing::NiceMock;
using testing::Pointee;
using testing::Return;
using testing::ReturnNew;
using testing::ReturnRef;
using testing::SaveArg;

namespace Envoy {
Expand Down
1 change: 0 additions & 1 deletion test/common/upstream/conn_pool_map_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

using testing::AtLeast;
using testing::Invoke;
using testing::InvokeArgument;
using testing::NiceMock;
using testing::Return;
using testing::SaveArg;
Expand Down
3 changes: 0 additions & 3 deletions test/common/upstream/eds_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
#include "gtest/gtest.h"

using testing::_;
using testing::AtLeast;
using testing::Return;
using testing::ReturnRef;

namespace Envoy {
namespace Upstream {
Expand Down
2 changes: 0 additions & 2 deletions test/common/upstream/health_checker_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,9 @@ using testing::InSequence;
using testing::Invoke;
using testing::InvokeWithoutArgs;
using testing::NiceMock;
using testing::Ref;
using testing::Return;
using testing::ReturnRef;
using testing::SaveArg;
using testing::WithArg;

namespace Envoy {
namespace Upstream {
Expand Down
Loading