Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotrestart: remove dynamic_resources from config used by hotrestart_test #8162

Merged
merged 1 commit into from
Sep 6, 2019
Merged

hotrestart: remove dynamic_resources from config used by hotrestart_test #8162

merged 1 commit into from
Sep 6, 2019

Commits on Sep 5, 2019

  1. hotrestart: remove dynamic_resources from server config used by hotre… 

    …start_test

In the server config file `test/config/integration/server.yaml` used by
//test/integration:hotrestart_test, `dynamic_resources` includes `lds_config`
and `cds_config` definitions, which use HTTP API to fetch config, but CDS and
LDS service do not exist, so the initial fetch will be failed with a
connection failure, then Envoy server continue startup.

Envoy server shouldn't continue startup because connection failure, see
issue envoyproxy#8046.

For this test, `dynamic_resources` is not needed, this change clean it up.

Signed-off-by: lhuang8 <lhuang8@ebay.com>
    lhuang8 authored and Lei committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    01541a4 View commit details
    Browse the repository at this point in the history